Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shadow to chips in dark mode #1344

Conversation

tobias-groeger
Copy link
Contributor

Currently chips do not have a visible shadow during dark mode.
Make the shadow of the chips dependent on the theme and darken the shadow when dark mode is enabled.

This approach is already used by the Welcome Scenes Card, which applies it specifically for the chips they used.
This is no longer necessary when we apply this modification to all chips.

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • I have followed the contribution guidelines
    • This PR is for a custom-card or documentation change and therefore directed to the main branch.
    • This PR is for a official card or any other directly to the integration related change and therefore directed to the release branch.

@basbruss basbruss merged commit 7139671 into UI-Lovelace-Minimalist:release Jul 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants