Update custom_card_person_info - Include Locality #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an additional variable for Locality, I didn't want the entire address but rather the Suburb Simple tweak
basbruss
reviewed
Jun 28, 2022
custom_cards/custom_card_person_info/custom_card_person_info.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: BasBruss <68892092+basbruss@users.noreply.github.com>
|
Thanks @basbruss appreciate your feedback, I must admit I'm very much a noob just giving things a crack, and this one between friends was a big success so felt maybe the community could benefit. |
|
@tgcowell Hi, typing error, alm_adress_locality 😄
|
... well that's embarrassing! making the change now. Cheers |
Adjusted variable ulm_address_locality as had it listed as alm ...
basbruss
previously approved these changes
Jun 29, 2022
basbruss
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to change the 'charging' to a capital in order for it to work ... maybe this is just an iPhone!
I've also added the locality option as a variable as I prefer to see a suburb over the full address.
hopefully this isn't an issue? I felt like it might help others?