Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hvac_action optional on ulm_translation_hvac #867

Conversation

mpeterson
Copy link
Contributor

Some climate entities do not have the hvac_action attribute and in those
cases the translation ends up with '(undefined)' as the mode part. This
is undesirable, and thus this PR removes it from the translation in case
there is no hvac_action attribute.

@mpeterson mpeterson force-pushed the feature/ulm_translation_hvac_optional_mode branch from 45690ad to f10ad35 Compare July 20, 2022 10:34
@basbruss
Copy link
Collaborator

basbruss commented Jul 21, 2022

@mpeterson
PR's for official cards/backend framework should be directed to the release branch as stated in the contribution.md

Some climate entities do not have the hvac_action attribute and in those
cases the translation ends up with '(undefined)' as the mode part. This
is undesirable, and thus this PR removes it from the translation in case
there is no hvac_action attribute.
@mpeterson mpeterson force-pushed the feature/ulm_translation_hvac_optional_mode branch from f10ad35 to 13dbb6f Compare July 21, 2022 07:10
@mpeterson mpeterson changed the base branch from main to release July 21, 2022 07:11
@mpeterson
Copy link
Contributor Author

@basbruss Thanks, I didn't know. I did look for a CONTRIBUTE.md file but couldn't find any and now after you told me looked again and still can't find any. Are you sure there is one?

In any case I rebased and changed base branch.

@mpeterson
Copy link
Contributor Author

@basbruss found it in .github ! I'll read it now

@basbruss
Copy link
Collaborator

basbruss commented Jul 21, 2022

I did look for a CONTRIBUTE.md file but couldn't find any and now after you told me looked again and still can't find any. Are you sure there is one?

It is located in the .github folder: https://github.com/UI-Lovelace-Minimalist/UI/blob/main/.github/CONTRIBUTING.md
And there are also references underneath a PR added by Github. (But are not that prominent placed)
image

Thanks for your contributions 😉

@mpeterson
Copy link
Contributor Author

I did look for a CONTRIBUTE.md file but couldn't find any and now after you told me looked again and still can't find any. Are you sure there is one?

It is located in the .github folder: https://github.com/UI-Lovelace-Minimalist/UI/blob/main/.github/CONTRIBUTING.md And there are also references underneath a PR added by Github. image

Oh, wow. I would have never seen that small information block from GitHub. Really bad placement there :)

Thanks for your contributions 😉

for sure! Thanks to you and all the other maintainers. I really enjoy using the project.

@basbruss basbruss merged commit 39c3316 into UI-Lovelace-Minimalist:release Jul 21, 2022
@mpeterson mpeterson deleted the feature/ulm_translation_hvac_optional_mode branch July 21, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants