Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚡ 重制相关项目组件 ⭐ 解决#37 #38

Merged
merged 19 commits into from
Nov 3, 2023
Merged

⚡ 重制相关项目组件 ⭐ 解决#37 #38

merged 19 commits into from
Nov 3, 2023

Conversation

MoRanYue
Copy link
Contributor

@MoRanYue MoRanYue commented Oct 29, 2023 •
edited by Masterain98
Loading

resolve #37

@netlify
Copy link

netlify bot commented Oct 29, 2023 •
edited
Loading

✅ Deploy Preview for uigf ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 69438df
🔍 Latest deploy log https://app.netlify.com/sites/uigf/deploys/6543bb3f8a83b10008eb1275
😎 Deploy Preview https://deploy-preview-38--uigf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 87 (🟢 up 2 from production)
Accessibility: 96 (no change from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@MoRanYue MoRanYue mentioned this pull request Oct 29, 2023
Closed
@Masterain98 Masterain98 changed the title ⚡ 重制相关项目组件 ⭐ ⚡ 重制相关项目组件 ⭐ resolve #37 Oct 29, 2023
@BTMuli BTMuli linked an issue Oct 29, 2023 that may be closed by this pull request
为 SiteInfo Box 添加一个 Wrap 以标注程序支持的标准版本 #37
Closed
@MoRanYue MoRanYue closed this Oct 29, 2023
@BTMuli BTMuli reopened this Oct 29, 2023
Masterain98
Masterain98 requested changes Oct 30, 2023
View reviewed changes
Copy link
Member

@Masterain98 Masterain98 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 亮色主题下的遮罩效果是暗色主题的
    image
  2. 使用相对路径的preview图片没有正确加载
    image
  3. 右下角的 GitHub 图标按钮，指针悬浮时会出现一个类似悬浮超链接的下划线 （未测试其它图标）
    image
  4. 点击box时，如果位置正好是中间的logo，浏览器不仅会在新tab中打开页面，还会在当前页面打开图片
    image

@Lightczx
Copy link
Member

4. 点击box时，如果位置正好是中间的logo，浏览器不仅会在新tab中打开页面，还会在当前页面打开图片

Epic!!!

@MoRanYue
Copy link
Contributor Author

点击box时，如果位置正好是中间的logo，浏览器不仅会在新tab中打开页面，还会在当前页面打开图片

az，我也不知道怎么回事呀，可能是这个项目有加什么插件吧？
只要点击到img元素，就会进入大图模式，也不知道如何取消呀！

@BTMuli
Copy link
Member

BTMuli commented Oct 30, 2023

MoRanYue#2 @Kamisato-Ayaka-233

MoRanYue and others added 6 commits October 30, 2023 19:44
@MoRanYue
🐛 修复源站点图片加载错误
8a50f36 
🐛 让图片不可点击，以达到禁用大图模式的效果
🎨 使缩放后的背景图片位于中心
🎨 取消左上角与右下角链接的下划线
🔥 忽略code-workspace的提交
@MoRanYue
✨ RelativeProject组件增加浅色模式时的样式
c13b0b2 
🎨 依赖增加vueuse
@BTMuli
💄 调整色彩
3532229
@BTMuli
💄 调整 UIGF 渐变
f43bf13
@BTMuli
💄 调整间距
729c68f
@MoRanYue
Merge pull request #3 from BTMuli/main
7c50d02 
💄 调整色彩
Masterain98
Masterain98 requested changes Nov 1, 2023
View reviewed changes
Copy link
Member

@Masterain98 Masterain98 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kamisato-Ayaka-233 在自动识别主题时，判定亮色情况下，遮罩效果仍然是暗色的。但手动切换到亮色主题时是没问题的。

image

@Lightczx Lightczx self-requested a review November 2, 2023 03:45
@MoRanYue
Copy link
Contributor Author

MoRanYue commented Nov 2, 2023 •
edited
Loading

@Kamisato-Ayaka-233 在自动识别主题时，判定亮色情况下，遮罩效果仍然是暗色的。但手动切换到亮色主题时是没问题的。

image

（或许应该试着把prefers-color-scheme添加事件监听器的函数调到外面？）

@BTMuli

@MoRanYue MoRanYue changed the title ⚡ 重制相关项目组件 ⭐ resolve #37 ⚡ 重制相关项目组件 ⭐ 解决#37 Nov 2, 2023
Masterain98
Masterain98 requested changes Nov 3, 2023
View reviewed changes
Copy link
Member

@Masterain98 Masterain98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

第一次访问页面时，自动主题下遮罩效果是正确的，但在右上角点击一轮再回到自动时，遮罩效果是错误的

@Lightczx Lightczx merged commit 364ebb7 into UIGF-org:main Nov 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Masterain98 Masterain98 Masterain98 requested changes

@Lightczx Lightczx Awaiting requested review from Lightczx

Assignees

@Masterain98 Masterain98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

为 SiteInfo Box 添加一个 Wrap 以标注程序支持的标准版本
4 participants
@MoRanYue @Lightczx @BTMuli @Masterain98