ZC RO Bcast: Send message to CmiNodeFirst(t.parent) instead of t.parent #2290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t.parent represents the logical node, which is the parent of my node. However, CmiSyncSendAndFree expects a PE for its first argument and for that reason, the ROChildCompletionMsg should be sent to the first PE of the parent.
matthiasdiener
approved these changes
May 31, 2019
stwhite91
approved these changes
Jun 3, 2019
epmikida
pushed a commit
that referenced
this pull request
Jun 17, 2019
…nt (#2290) t.parent represents the logical node, which is the parent of my node. However, CmiSyncSendAndFree expects a PE for its first argument and for that reason, the ROChildCompletionMsg should be sent to the first PE of the parent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
t.parent represents the logical node, which is the parent of my node.
However, CmiSyncSendAndFree expects a PE for its first argument and for that
reason, the ROChildCompletionMsg should be sent to the first PE of the parent.
This fixes the crash seen in #2286.
However, the hang seen in #2286 is still unfixed because of QD support missing/being incorrect for the ZC API.