Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(DTFS-7052): added GET /geospatial/addresses/postcode endpoint for Ordnance Survey API data #804

Merged
merged 61 commits into from
May 13, 2024
Merged

feat(DTFS-7052): added GET /geospatial/addresses/postcode endpoint for Ordnance Survey API data #804

merged 61 commits into from
May 13, 2024

Commits on Apr 10, 2024

  1. feat(DTFS2-7052): new API modules and endpoint /api/v1/geospatial/add… 

    …resses/postcode?postcode=W1A1AA
    @avaitonis
    avaitonis committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    2cdd0de View commit details
    Browse the repository at this point in the history

  2. feat(DTFS2-7052): new module geospatial

    @avaitonis
    avaitonis committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    14a6a08 View commit details
    Browse the repository at this point in the history

  3. feat(DTFS2-7052): fixed lint errors

    @avaitonis
    avaitonis committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    17fea54 View commit details
    Browse the repository at this point in the history

  4. feat(DTFS2-7052): adding constants and examples

    @avaitonis
    avaitonis committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    a3d5433 View commit details
    Browse the repository at this point in the history

  5. feat(DTFS2-7052): adding typescript include for json files, to satify… 

    … lint. I added big examples to json files
    @avaitonis
    avaitonis committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    0b79772 View commit details
    Browse the repository at this point in the history

  6. feat(DTFS2-7052): trying to automate husky run on commit

    @avaitonis
    avaitonis committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    1b6cf30 View commit details
    Browse the repository at this point in the history

  7. feat(DTFS2-7052): trying to automate husky run on commit

    @avaitonis
    avaitonis committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    5fbf3d7 View commit details
    Browse the repository at this point in the history

  8. feat(DTFS2-7052): change husky install to same way as in DTFS project

    @avaitonis
    avaitonis committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    889fe1b View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. feat(DTFS2-7052): work in progress of geospatial-get-address api tests

    @avaitonis
    avaitonis committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    21f8006 View commit details
    Browse the repository at this point in the history

  2. feat(DTFS2-7052): package update

    @avaitonis
    avaitonis committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    3259347 View commit details
    Browse the repository at this point in the history

  3. feat(DTFS2-7052): api-tests for geospatial/get-address-by-postcode

    @avaitonis
    avaitonis committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    c8cb1bc View commit details
    Browse the repository at this point in the history

  4. feat(DTFS2-7052): refactor api tests to match TFS and solve type issues

    @avaitonis
    avaitonis committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    c91144d View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. feat(DTFS2-7052): tests for ordnance survey API endpoint

    @avaitonis
    avaitonis committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    837a482 View commit details
    Browse the repository at this point in the history

  2. feat(DTFS2-7052): fix address line 1 formating

    @avaitonis
    avaitonis committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    db50210 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into feat/DTFS2-7052/new-e… 

    …xternal-ordnance-survey-api
    @avaitonis
    avaitonis committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    0d86a35 View commit details
    Browse the repository at this point in the history

  4. feat(DTFS2-7052): spelling fix

    @avaitonis
    avaitonis committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    4c503ca View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. feat(DTFS2-7052): renaming enums/geospatial.ts to enums/geospatialCou… 

    …ntries.ts
    @avaitonis
    avaitonis committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    252b5a1 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into feat/DTFS2-7052/new-e… 

    …xternal-ordnance-survey-api
    @avaitonis
    avaitonis committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    e9750f4 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Update src/modules/geospatial/geospatial.controller.test.ts 

    Co-authored-by: oscar-richardson-softwire <116292912+oscar-richardson-softwire@users.noreply.github.com>
    @avaitonis @oscar-richardson-softwire
    avaitonis and oscar-richardson-softwire committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    f33edc5 View commit details
    Browse the repository at this point in the history

  2. Update src/modules/geospatial/geospatial.controller.test.ts 

    Co-authored-by: oscar-richardson-softwire <116292912+oscar-richardson-softwire@users.noreply.github.com>
    @avaitonis @oscar-richardson-softwire
    avaitonis and oscar-richardson-softwire committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    b673376 View commit details
    Browse the repository at this point in the history

  3. Update src/modules/geospatial/geospatial.controller.test.ts 

    Co-authored-by: oscar-richardson-softwire <116292912+oscar-richardson-softwire@users.noreply.github.com>
    @avaitonis @oscar-richardson-softwire
    avaitonis and oscar-richardson-softwire committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    fb2d4bc View commit details
    Browse the repository at this point in the history

  4. Update src/modules/geospatial/geospatial.controller.test.ts 

    Co-authored-by: oscar-richardson-softwire <116292912+oscar-richardson-softwire@users.noreply.github.com>
    @avaitonis @oscar-richardson-softwire
    avaitonis and oscar-richardson-softwire committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    b7a727c View commit details
    Browse the repository at this point in the history

  5. Update src/modules/geospatial/geospatial.service.test.ts 

    Co-authored-by: oscar-richardson-softwire <116292912+oscar-richardson-softwire@users.noreply.github.com>
    @avaitonis @oscar-richardson-softwire
    avaitonis and oscar-richardson-softwire committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    841268f View commit details
    Browse the repository at this point in the history

  6. Update src/modules/geospatial/geospatial.service.test.ts 

    Co-authored-by: oscar-richardson-softwire <116292912+oscar-richardson-softwire@users.noreply.github.com>
    @avaitonis @oscar-richardson-softwire
    avaitonis and oscar-richardson-softwire committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    7f1110d View commit details
    Browse the repository at this point in the history

  7. feat(DTFS2-7052): improve address test data

    @avaitonis
    avaitonis committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    ff5ac7b View commit details
    Browse the repository at this point in the history

  8. Merge branch 'feat/DTFS2-7052/new-external-ordnance-survey-api' of ht… 

    …tps://github.com/UK-Export-Finance/mdm-api into feat/DTFS2-7052/new-external-ordnance-survey-api
    @avaitonis
    avaitonis committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    df90b33 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. feat(DTFS2-7052): applying Oscars suggestions on my PR

    @avaitonis
    avaitonis committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    f68ac66 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. feat(DTFS2-7052): moving uk postcode regex to constants and doc impro… 

    …vements
    @avaitonis
    avaitonis committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    75b34ac View commit details
    Browse the repository at this point in the history

  2. feat(DTFS2-7052): comments copy and variable name improvements

    @avaitonis
    avaitonis committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    5a0ee93 View commit details
    Browse the repository at this point in the history

  3. feat(DTFS2-7052): typescript type improvement in api-test helper

    @avaitonis
    avaitonis committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    6bf5a4d View commit details
    Browse the repository at this point in the history

  4. feat(DTFS2-7052): moving address examples to constants

    @avaitonis
    avaitonis committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    de7a0e5 View commit details
    Browse the repository at this point in the history

  5. feat(DTFS2-7052): updating spec snapshot

    @avaitonis
    avaitonis committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    c7ac787 View commit details
    Browse the repository at this point in the history

  6. Update src/modules/geospatial/dto/get-addresses-response.dto.ts 

    Co-authored-by: oscar-richardson-softwire <116292912+oscar-richardson-softwire@users.noreply.github.com>
    @avaitonis @oscar-richardson-softwire
    avaitonis and oscar-richardson-softwire committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    14ea1e6 View commit details
    Browse the repository at this point in the history

  7. Update src/modules/geospatial/dto/get-addresses-response.dto.ts 

    Co-authored-by: oscar-richardson-softwire <116292912+oscar-richardson-softwire@users.noreply.github.com>
    @avaitonis @oscar-richardson-softwire
    avaitonis and oscar-richardson-softwire committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    1c0bf2c View commit details
    Browse the repository at this point in the history

  8. Update src/modules/geospatial/dto/get-addresses-response.dto.ts 

    Co-authored-by: oscar-richardson-softwire <116292912+oscar-richardson-softwire@users.noreply.github.com>
    @avaitonis @oscar-richardson-softwire
    avaitonis and oscar-richardson-softwire committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    129b364 View commit details
    Browse the repository at this point in the history

  9. Update src/modules/geospatial/dto/get-addresses-response.dto.ts 

    Co-authored-by: oscar-richardson-softwire <116292912+oscar-richardson-softwire@users.noreply.github.com>
    @avaitonis @oscar-richardson-softwire
    avaitonis and oscar-richardson-softwire committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    2733003 View commit details
    Browse the repository at this point in the history

  10. feat(DTFS2-7052): updating api spec definition

    @avaitonis
    avaitonis committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    fa73657 View commit details
    Browse the repository at this point in the history

  11. feat(DTFS2-7052): updating api spec snapshot

    @avaitonis
    avaitonis committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    3e215d7 View commit details
    Browse the repository at this point in the history

  12. Update src/modules/geospatial/geospatial.controller.ts 

    Co-authored-by: oscar-richardson-softwire <116292912+oscar-richardson-softwire@users.noreply.github.com>
    @avaitonis @oscar-richardson-softwire
    avaitonis and oscar-richardson-softwire committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    70e5861 View commit details
    Browse the repository at this point in the history

  13. Update src/modules/geospatial/geospatial.controller.ts 

    Co-authored-by: oscar-richardson-softwire <116292912+oscar-richardson-softwire@users.noreply.github.com>
    @avaitonis @oscar-richardson-softwire
    avaitonis and oscar-richardson-softwire committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    021bdd4 View commit details
    Browse the repository at this point in the history

  14. Update src/modules/geospatial/geospatial.controller.test.ts 

    Co-authored-by: oscar-richardson-softwire <116292912+oscar-richardson-softwire@users.noreply.github.com>
    @avaitonis @oscar-richardson-softwire
    avaitonis and oscar-richardson-softwire committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    d546834 View commit details
    Browse the repository at this point in the history

  15. Update src/modules/geospatial/geospatial.controller.test.ts 

    Co-authored-by: oscar-richardson-softwire <116292912+oscar-richardson-softwire@users.noreply.github.com>
    @avaitonis @oscar-richardson-softwire
    avaitonis and oscar-richardson-softwire committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    5cc2412 View commit details
    Browse the repository at this point in the history

  16. Update test/geospatial/get-address-by-postcode.api-test.ts 

    Co-authored-by: oscar-richardson-softwire <116292912+oscar-richardson-softwire@users.noreply.github.com>
    @avaitonis @oscar-richardson-softwire
    avaitonis and oscar-richardson-softwire committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    ad617e2 View commit details
    Browse the repository at this point in the history

  17. Update src/modules/geospatial/geospatial.service.test.ts 

    Co-authored-by: oscar-richardson-softwire <116292912+oscar-richardson-softwire@users.noreply.github.com>
    @avaitonis @oscar-richardson-softwire
    avaitonis and oscar-richardson-softwire committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    67d682e View commit details
    Browse the repository at this point in the history

  18. Update test/geospatial/get-address-by-postcode.api-test.ts 

    Co-authored-by: oscar-richardson-softwire <116292912+oscar-richardson-softwire@users.noreply.github.com>
    @avaitonis @oscar-richardson-softwire
    avaitonis and oscar-richardson-softwire committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    708533b View commit details
    Browse the repository at this point in the history

  19. feat(DTFS2-7052): actioning PR comments

    @avaitonis
    avaitonis committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    7d15b07 View commit details
    Browse the repository at this point in the history

  20. feat(DTFS2-7052): actioning PR comments

    @avaitonis
    avaitonis committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    e012eb4 View commit details
    Browse the repository at this point in the history

  21. feat(DTFS2-7052): updating API spec

    @avaitonis
    avaitonis committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    15743c0 View commit details
    Browse the repository at this point in the history

  22. feat(DTFS2-7052): changing variables to use plural

    @avaitonis
    avaitonis committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    c020867 View commit details
    Browse the repository at this point in the history

  23. Update test/support/generator/get-geospatial-addresses-generator.ts 

    Co-authored-by: oscar-richardson-softwire <116292912+oscar-richardson-softwire@users.noreply.github.com>
    @avaitonis @oscar-richardson-softwire
    avaitonis and oscar-richardson-softwire committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    e1ecd0d View commit details
    Browse the repository at this point in the history

  24. Update src/helper-modules/ordnance-survey/ordnance-survey.service.tes… 

    …t.ts

Co-authored-by: oscar-richardson-softwire <116292912+oscar-richardson-softwire@users.noreply.github.com>
    @avaitonis @oscar-richardson-softwire
    avaitonis and oscar-richardson-softwire committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    a6f33b4 View commit details
    Browse the repository at this point in the history

  25. Update src/helper-modules/ordnance-survey/ordnance-survey.service.tes… 

    …t.ts

Co-authored-by: oscar-richardson-softwire <116292912+oscar-richardson-softwire@users.noreply.github.com>
    @avaitonis @oscar-richardson-softwire
    avaitonis and oscar-richardson-softwire committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    370c342 View commit details
    Browse the repository at this point in the history

  26. Update src/helper-modules/ordnance-survey/ordnance-survey.service.tes… 

    …t.ts

Co-authored-by: oscar-richardson-softwire <116292912+oscar-richardson-softwire@users.noreply.github.com>
    @avaitonis @oscar-richardson-softwire
    avaitonis and oscar-richardson-softwire committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    90eb4d3 View commit details
    Browse the repository at this point in the history

  27. feat(DTFS2-7049): adding new env variables to docker-compose.yml

    @avaitonis
    avaitonis committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    3ca57f0 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. feat(DTFS2-7052): downgrade @commitlint/cli from 19.3.0 to 18.6.0

    @avaitonis
    avaitonis committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    132d179 View commit details
    Browse the repository at this point in the history

  2. feat(DTFS2-7052): removing unused class GetSearchPostcodeOrdnanceSurv… 

    …eyQueryDto
    @avaitonis
    avaitonis committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    32aa1ef View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. feat(DTFS2-7052): code style improvements based on PR feedback

    @avaitonis
    avaitonis committed May 13, 2024
    Configuration menu
    Copy the full SHA
    38939db View commit details
    Browse the repository at this point in the history

  2. feat(DTFS2-7052): change GET /geospatial/addresses/postcode?postcode=… 

    … empty response from 200 to 404
    @avaitonis
    avaitonis committed May 13, 2024
    Configuration menu
    Copy the full SHA
    33c9e65 View commit details
    Browse the repository at this point in the history

  3. feat(DTFS2-7052): changed numeric status code 200 to HttpStatus.OK, b… 

    …ut just in controller
    @avaitonis
    avaitonis committed May 13, 2024
    Configuration menu
    Copy the full SHA
    3751992 View commit details
    Browse the repository at this point in the history

  4. feat(DTFS2-7052): changed documentation for .env setting ORDNANCE_SUR… 

    …VEY_URL
    @avaitonis
    avaitonis committed May 13, 2024
    Configuration menu
    Copy the full SHA
    18fdf4a View commit details
    Browse the repository at this point in the history

  5. feat(DTFS2-7052): tidying up map function

    @avaitonis
    avaitonis committed May 13, 2024
    Configuration menu
    Copy the full SHA
    0da25c3 View commit details
    Browse the repository at this point in the history