Partial fix for 404 on missing entity #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two cases to handle. This patch handles the case where the request has no flags by validating entity graph to check external refs. If the request is _view=with_metadata then we also have to run a similar check. However, a number of existing test cases currently fail because they (accidentally) use external items. Partially addresses: #159
|
Needs a test case, not yet ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two cases to handle.
This patch handles the case where the request has no flags
by validating entity graph to check external refs.
If the request is
_view=with_metadatathen we also have to runa similar check. However, a number of existing test cases
currently fail because they (accidentally) use external items.
Partially addresses: #159