Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(2929) Published to IATI value in report csv #2259

Merged
merged 2 commits into from Nov 28, 2023
Merged

(2929) Published to IATI value in report csv #2259

merged 2 commits into from Nov 28, 2023

Conversation

mec
Copy link
Collaborator

@mec mec commented Nov 27, 2023 •
edited

Changes in this PR

This work adds the publish_to_iati from Activity value in the report csv export.

  • The value is true by default
  • The value is shown as one of 'Yes' or 'No'
  • The column comes at the very end of the columns in the csv table

https://trello.com/c/c4GFG0UW

@mec mec force-pushed the feature/2929-iati-published-state-in-report-csv-export branch from f0ec2fc to cac1eec Compare November 27, 2023 14:02
@mec mec marked this pull request as ready for review November 27, 2023 14:03
@mec mec force-pushed the feature/2929-iati-published-state-in-report-csv-export branch 3 times, most recently from 0858f66 to a101beb Compare November 28, 2023 08:40
CristinaRO
CristinaRO approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@CristinaRO CristinaRO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had another thought to help with the past tense unease, if you agree! Wouldn't make you fiddle with the spec description so much, but in this case it feels like an accurate spec description might help everyone!

spec/models/export/activity_iati_column_spec.rb Outdated Show resolved Hide resolved
@mec
Add ActivityIATIColumn
70a72a5 
We have an interface for adding columns or collection of columns to the
report csv export. Here we add a new colum, 'Published on IATI' which
includes the state of the `Activity` `publish_to_iati' value.

Publish_to_iati is true by default.
@mec
Add the Published on IATI value to the report csv
62b9280 
This adds the new Export::ActivityIatiColumn to the report csv export.
@mec mec force-pushed the feature/2929-iati-published-state-in-report-csv-export branch from a101beb to 62b9280 Compare November 28, 2023 11:49
@mec mec merged commit 470394c into develop Nov 28, 2023
4 checks passed
@mec mec deleted the feature/2929-iati-published-state-in-report-csv-export branch November 28, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CristinaRO CristinaRO CristinaRO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mec @CristinaRO