(2965) Clean up leftovers from "ISPF in stealth mode" feature flag #2264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CristinaRO
force-pushed
the
2965-clean-up-some-leftover-mentions-of-isfp-in-stealth-mode
branch
from
85355b0
to
c5f844b
Compare
The feature flag allowing everything to do with ISPF to be hidden has been removed in #2192 This spec has escaped our notice because it was not using the feature flag by name. Instead, it relied on a proxy for the flag being on or off in the form of the funds being loaded in the exports controller as `Fund.all` or `Fund.not_ispf`. Since the flag has been removed, there are no conditions under which the funds being loaded on the exports page are restricted to non-ISPF only.
Scopes and methods to return all but ISPF funds, activities, and reports are now unused. They were only in use when the app had a feature flag to enable hiding everything to do with ISPF. I did hesitate for a bit about keeping this code "just in case", but ultimately we know that in general, unused code is a recipe for confusion and an increased burden of maintenance, and it can always be added back if it's needed in future.
CristinaRO
force-pushed
the
2965-clean-up-some-leftover-mentions-of-isfp-in-stealth-mode
branch
from
c5f844b
to
20e3076
Compare
shuldt
approved these changes
Nov 30, 2023
CristinaRO
deleted the
2965-clean-up-some-leftover-mentions-of-isfp-in-stealth-mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR
not_ispfScreenshots of UI changes
N/A
Next steps
CHANGELOG.md, unless this PR is a small tweak which has no impact outside the development team.