Alias health_check so it responds to health-check #2271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CristinaRO
force-pushed
the
3000-application-health-check
branch
from
58211c2
to
e86f7c3
Compare
The AWS health check endpoint has been configured to look for the route `health-check` instead of `health_check`. Rather than asking them to reconfigure it, we will accept that both versions (with dash and with underscore) are common, and provide an alias for the route, so that it responds to both requests.
CristinaRO
force-pushed
the
3000-application-health-check
branch
from
e86f7c3
to
c3e7210
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR
The AWS health check endpoint has been configured to look for the route
health-checkinstead ofhealth_check.Rather than asking them to reconfigure it, we will accept that both versions (with dash and with underscore) are common, and provide an alias for the route, so that it responds to both requests.
Screenshots of UI changes
N/A
Next steps
CHANGELOG.md, unless this PR is a small tweak which has no impact outside the development team.