Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(2978) Set X-XSS-Protection header to 0 #2274

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

CristinaRO
Copy link
Collaborator

Changes in this PR

  • Set the X-XSS-Protection header to 0 (disabled)

Screenshots of UI changes

N/A

Next steps

  • Is an ADR required? An ADR should be added if this PR introduces a change to the architecture.
  • Is a changelog entry required? An entry should always be made in CHANGELOG.md, unless this PR is a small tweak which has no impact outside the development team.
  • Do any environment variables need amending or adding?
  • Have any changes to the XML been checked with the IATI validator? See XML Validation

Recommendation from pen test:
The X-XSS-Protection header is non-standard. The recommendation is to
set it to 0 (i.e. disabled) as it can create vulnerabilities:
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-XSS-Protection
@CristinaRO
Copy link
Collaborator Author

Copy link
Collaborator

@mec mec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@CristinaRO CristinaRO merged commit 15c9118 into develop Dec 5, 2023
4 checks passed
@CristinaRO CristinaRO deleted the 2978-set-x-xss-protection-header-to-0 branch December 5, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants