Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(2931/1) Model a financial value from a csv #2284

Merged
merged 1 commit into from
Jan 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
[Full changelog][unreleased]

- Display the budgets headings as "Activity budgets" for level C and D activities on the Financials tab
- model a financial value from a csv file

## Release 141 - 2023-12-04

Expand Down
19 changes: 19 additions & 0 deletions app/models/import/csv/financial.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
class Import::Csv::Financial
attr_reader :decimal_value, :original_value

def initialize(value)
@decimal_value = convert_to_decimal(value.to_s)
@original_value = value.to_s
end

private def convert_to_decimal(value)
return BigDecimal("0") if value.blank?

begin
converted_value = ConvertFinancialValue.new.convert(value)
rescue ConvertFinancialValue::Error
return nil
end
converted_value
end
end
106 changes: 106 additions & 0 deletions spec/models/import/csv/financial_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,106 @@
require "rails_helper"

RSpec.describe Import::Csv::Financial do
describe "#value" do
context "when the value is positive number" do
it "returns a BigDecimal of the number" do
csv_value = "1000.0"
finance_value = described_class.new(csv_value)

expect(finance_value.decimal_value).to eql BigDecimal("1_000")
end
end

context "when the value is negative number" do
it "returns a BigDecimal of the number" do
csv_value = "-1000.0"
finance_value = described_class.new(csv_value)

expect(finance_value.decimal_value).to eql BigDecimal("-1_000")
end
end

context "when the value is zero" do
it "returns a BigDecimal of zero" do
csv_value = "0.0"
finance_value = described_class.new(csv_value)

expect(finance_value.decimal_value).to eql BigDecimal("0")
end
end

context "when the value has financial punctuation" do
it "returns a BigDecimal of the number" do
csv_value = "£1,000,000,000.0"
finance_value = described_class.new(csv_value)

expect(finance_value.decimal_value).to eql BigDecimal("1_000_000_000")
end
end

context "when the value is space" do
it "returns a BigDecimal of zero" do
csv_value = " "
finance_value = described_class.new(csv_value)

expect(finance_value.decimal_value).to eql BigDecimal("0")
end
end

context "when the value is multiple spaces" do
it "returns a BigDecimal of zero" do
csv_value = " "
finance_value = described_class.new(csv_value)

expect(finance_value.decimal_value).to eql BigDecimal("0")
end
end

context "when the value is nil" do
it "returns a BigDecimal of zero" do
csv_value = nil
finance_value = described_class.new(csv_value)

expect(finance_value.decimal_value).to eql BigDecimal("0")
end
end

context "when the value is empty" do
it "returns a BigDecimal of zero" do
csv_value = ""
finance_value = described_class.new(csv_value)

expect(finance_value.decimal_value).to eql BigDecimal("0")
end
end

context "when the value cannot be converted" do
it "returns nil" do
csv_value = "this cannot be converted"
finance_value = described_class.new(csv_value)

expect(finance_value.decimal_value).to be_nil
end
end
end

describe "#original_value" do
context "when the conversion can take place" do
it "returns the original string from the csv cell" do
csv_value = "1000.0"
finance_value = described_class.new(csv_value)

expect(finance_value.original_value).to eql csv_value
end
end

context "when the conversion cannot take place" do
it "returns the original string from the csv cell" do
csv_value = "ten thousand pounds"
finance_value = described_class.new(csv_value)

expect(finance_value.original_value).to eql csv_value
end
end
end
end