(2931/4) Actual, Refund or Comment csv file import service #2304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuldt
force-pushed
the
feature/2931-actual-refund-comment-csv-file-import-service
branch
3 times, most recently
from
4963bbc
to
35c407b
Compare
mec
changed the title
mec
changed the title
mec
changed the title
mec
changed the title
mec
force-pushed
the
feature/2931-actual-refund-comment-csv-file-import-service
branch
from
35c407b
to
e396ddb
Compare
CristinaRO
reviewed
Jan 15, 2024
spec/models/import/row_error_spec.rb
Outdated
| end | ||
| end | ||
|
|
||
| describe "#csv_row" do |
There was a problem hiding this comment.
I'd prefer if this method was named csv_row_number, to avoid confusion that it might refer to the CSV row being imported.
There was a problem hiding this comment.
Oh, this was named to be compatible with the existing importer and views - I've had to add it back in later! :(
CristinaRO
approved these changes
Jan 15, 2024
mec
force-pushed
the
feature/2931-actual-refund-comment-csv-file-import-service
branch
from
e396ddb
to
b2a7544
Compare
We want to reuse this error class for the activity, refund and comment import process, but to do so it needs to support the existing interface so that we can be compatible whilst the importer is switched to the new one that is in progress. All we need is a representation of the row as it appears in the csv data file, the users expectation of the row number. This is just a matter of the enumerable index plus 2. Adding this method has no impact on existing code. We also add a test.
This class is relatively straight forward, it is responsible for taking the uploaded csv data and running through them to import the data. It relies on the classes created in previous work to do so, It is concerned with: - checking the required column headers are present - collating the objects that the rows become on import - collating any errors from the import process - rolling back the database if there are errors Co-authored-by:shuldt <suze@dxw.com>
mec
force-pushed
the
feature/2931-actual-refund-comment-csv-file-import-service
branch
from
b2a7544
to
99bdbee
Compare
mec
deleted the
feature/2931-actual-refund-comment-csv-file-import-service
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR
This is the final part of the work to introduce a new Actual, Refund and Activity Comment import.
We update an existing
ErrorMessageso it can be used by the new import and work the same way as the existing one so that we can run both with minimal effort.With the error class updated we go on to the final service object, this one is concerned with:
It uses the classes introduced in previous work.
The next step will be to introduce a feature flag and switch importers based on it, we may also improve the UI based on the new importer.
https://trello.com/c/lBZkYq5c