Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download a list of non-continuing ODA activities #2310

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

CristinaRO
Copy link
Collaborator

Changes in this PR

To help DSIT with confirming the lists of activities that will and won't need to be updated with the new transparency identifier, allow them to export a list of the activities that are assumed to not continue under GB-GOV-26.

The reason we have used the criteria of elimination rather than a new standalone query is that this is how the migration is likely to look like in practice: activities that fulfill the continuation criteria will be updated, and all other activities will be left as they are.

Non-ODA activities are excluded from both, because they are not concerned with transparency reporting to begin with.

Screenshots of UI changes

Before

After

Screenshot 2024-01-15 at 15 58 41

Next steps

  • Is an ADR required? An ADR should be added if this PR introduces a change to the architecture.
  • Is a changelog entry required? An entry should always be made in CHANGELOG.md, unless this PR is a small tweak which has no impact outside the development team.
  • Do any environment variables need amending or adding?
  • Have any changes to the XML been checked with the IATI validator? See XML Validation

To help DSIT with confirming the lists of activities that will and won't
need to be updated with the new transparency identifier, allow them to
export a list of the activities that are assumed to not continue under
GB-GOV-26.

The reason we have used the criteria of elimination rather than a new
standalone query is that this is how the migration is likely to look
like in practice: activities that fulfill the continuation criteria will
be updated, and all other activities will be left as they are.

Non-ODA activities are excluded from both, because they are not
concerned with transparency reporting to begin with.
@CristinaRO CristinaRO requested a review from mec January 15, 2024 15:59
Copy link
Collaborator

@mec mec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the context for this, temporary solution to not having conosle access in production to allow for fact finding, happy for it to go in. 🚢

@CristinaRO CristinaRO merged commit 3c1711a into develop Jan 15, 2024
3 checks passed
@CristinaRO CristinaRO deleted the 3006-list-non-continuing-activities branch January 15, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants