Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(3027) Update the factory to use current rules #2316

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

CristinaRO
Copy link
Collaborator

Changes in this PR

The purpose of this change is to make the factory more realistic, to avoid it being a source of confusion as to how the transparency identifier is generated in RODA.

Screenshots of UI changes

N/A

Next steps

  • Is an ADR required? An ADR should be added if this PR introduces a change to the architecture.
  • Is a changelog entry required? An entry should always be made in CHANGELOG.md, unless this PR is a small tweak which has no impact outside the development team.
  • Do any environment variables need amending or adding?
  • Have any changes to the XML been checked with the IATI validator? See XML Validation

@CristinaRO CristinaRO force-pushed the make-factory-more-accurate branch 2 times, most recently from 262af25 to a71c692 Compare January 16, 2024 17:03
@CristinaRO
Copy link
Collaborator Author

@CristinaRO CristinaRO changed the title Update the factory to use current rules (3027) Update the factory to use current rules Jan 16, 2024
Copy link
Collaborator

@mec mec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

The purpose of this change is to make the factory more realistic, to
avoid it being a source of confusion as to how the transparency
identifier is generated in RODA.
@CristinaRO CristinaRO merged commit fc14a32 into develop Jan 17, 2024
1 check passed
@CristinaRO CristinaRO deleted the make-factory-more-accurate branch January 17, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants