(128) Activity form uses govuk form builder #90
Conversation
lozette
force-pushed
the
refactor/128-activity-form-uses-new-form-builder
branch
3 times, most recently
from
8b38626
to
db8b253
Compare
app/models/activity.rb
Outdated
| @@ -3,6 +3,10 @@ class Activity < ApplicationRecord | |||
| validates_presence_of :identifier | |||
| validates_uniqueness_of :identifier | |||
|
|
|||
| attribute :recipient_region, :string, default: "998" | |||
There was a problem hiding this comment.
I think these defaults will work fine for fund activities but I wonder how we'll be able to support these being changed for programmes and projects, any ideas?
There was a problem hiding this comment.
Possibly a set of env variables?
Or maybe a helper along the lines of ActivityHelper. Although if the values needed to change than env variables are probably more flexible?
There was a problem hiding this comment.
I hadn't thought of environment variables, how might that look?
I wonder if having some initializer helpers might help. Something like:
class Activity
def setup_hierarchy_defaults
case hierachy.class.name
when fund setup_fund_defaults
…
end
private def setup_fund_defaults
self.recipient_region = "998"
…
end
private def setup_programme_detaults
self.recipient_region = "2"
…
end
class Staff::ActivitiesController < Staff::BaseController
include ActivityHelper
def create
@activity.hierarchy = hierarchy
@activity.set_up_hierachy_defaults
@activity.save(validate: false)
…
If we can't see a way to extend the current attribute implementation, I think it may be best to lose as it would be a secondary way of setting defaults which makes it conceptually harder to follow and opens us up to accidentally applying the wrong defaults at the wrong level of hierarchy.
There was a problem hiding this comment.
I like the initialiser helpers more, env variables would be clunky and I don't think these values are going to change often (maybe?)
| @@ -1,15 +1,6 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| module CodelistHelper | |||
| # TODO: Remove `yaml_to_options` when all forms are migrated from simple form to the govuk form builder, | |||
There was a problem hiding this comment.
Good to see us closing the loop and binning the old version 👍
|
I think the asterisk for a required field is not part of the govuk design standard: https://govuk-elements.herokuapp.com/form-elements/#form-optional-fields |
|
@lozette Ah brilliant 👌 Really what we'd need if anything would be to add |
lozette
force-pushed
the
refactor/128-activity-form-uses-new-form-builder
branch
4 times, most recently
from
22395a3
to
b4263ce
Compare
- Use GOVUK design system form builder and helpers - Move setting defaults into the Activity model - Move model translations to models_and_forms.en.yml
…jects The latter is better supported by the new govuk forms
The defaults on the Activity model are Fund-specific. This change refactors the setting of default attributes so when we add other hierarchy types, we can add other defaults.
lozette
force-pushed
the
refactor/128-activity-form-uses-new-form-builder
branch
from
b4263ce
to
db04f3c
Compare
Changes in this PR
Trello: https://trello.com/c/AvIykhu2/128-refactor-activity-form-to-use-new-form-builder
All forms in the application now use
govuk_design_system_formbuilder.Next steps
CHANGELOG.md, unless this PR is a small tweak which has to impact outside the development team.