Skip to content
This repository has been archived by the owner on Aug 20, 2020. It is now read-only.

Moving to az do live subscription #24

Merged
merged 18 commits into from Aug 6, 2019
Merged

Moving to az do live subscription #24

merged 18 commits into from Aug 6, 2019

Conversation

elduddz
Copy link
Contributor

@elduddz elduddz commented Aug 2, 2019

  • using makefile for process management
  • experimenting with some secrets being encrypted in repo
  • using latest "stable" packer image
  • using F8s whilst we work out why F8s_V2 arent on the subscription

@elduddz elduddz requested a review from a team August 2, 2019 13:30
@ghost ghost requested a review from MarcDenman August 2, 2019 13:30
@elduddz elduddz changed the title Moving to az do live Moving to az do live subscription Aug 2, 2019
@elduddz elduddz added the DO NOT MERGE waiting on some approval to complete label Aug 2, 2019
Copy link
Contributor

@MarcDenman MarcDenman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can ./iptest-pipelines.yml be deleted? Is the documentation up to date? Are there any unit tests?

azure-pipelines.yml Outdated Show resolved Hide resolved
modules/azdo_ws2019agent/main.tf Outdated Show resolved Hide resolved
tfplan.sh Outdated Show resolved Hide resolved
tfplan.sh Outdated Show resolved Hide resolved
elduddz and others added 2 commits August 2, 2019 15:12
Co-Authored-By: Marc Denman <MarcDenman@users.noreply.github.com>
@elduddz elduddz removed the DO NOT MERGE waiting on some approval to complete label Aug 5, 2019
@elduddz
Copy link
Contributor Author

elduddz commented Aug 5, 2019

Can ./iptest-pipelines.yml be deleted? Is the documentation up to date? Are there any unit tests?

not sure what can I unit test?

@elduddz elduddz requested a review from a team August 6, 2019 07:35
@ghost ghost requested a review from crandon42 August 6, 2019 07:35
@elduddz elduddz removed the request for review from crandon42 August 6, 2019 14:09
@elduddz elduddz merged commit 4eed6ee into master Aug 6, 2019
@elduddz elduddz deleted the movingToAzDoLive branch August 22, 2019 15:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants