Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added networking components to Azure naming conventions #38

Merged

Conversation

tomling
Copy link
Contributor

@tomling tomling commented Aug 8, 2019

As part of this change (In collaboration with Andrew Poole) we have come up with finer grain naming conventions for networking components in Azure .

@tomling
Copy link
Contributor Author

tomling commented Aug 8, 2019

This is my first Github pull request (sorry if I've done it incorrectly) 😁

Copy link
Contributor

@MarcDenman MarcDenman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :) Can you double check the examples provided to the patterns please? A few don't have start with the Cloud Key though specified in the pattern, a few might be missing hyphens or the pattern have hyphens not needed, I don't know which!

@tomling
Copy link
Contributor Author

tomling commented Aug 8, 2019

Thank you :) Can you double check the examples provided to the patterns please? A few don't have start with the Cloud Key though specified in the pattern, a few might be missing hyphens or the pattern have hyphens not needed, I don't know which!

Thanks Marc I will add the cloud key to the examples. @thealmguy can you confirm if the hyphens are compulsory?

@elduddz
Copy link
Contributor

elduddz commented Aug 8, 2019

Thank you :) Can you double check the examples provided to the patterns please? A few don't have start with the Cloud Key though specified in the pattern, a few might be missing hyphens or the pattern have hyphens not needed, I don't know which!

Thanks Marc I will add the cloud key to the examples. @thealmguy can you confirm if the hyphens are compulsory?

hyphens are not compulsory if they will take you over the resource name limit

When using resources with short character limits, omit hypens as a first step

Copy link
Contributor

@elduddz elduddz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this branch needs to be committed before we close the naming conventions

tomling and others added 2 commits August 12, 2019 10:35
Changed M prefix to MS

Co-Authored-By: Luke Duddridge <338863+elduddz@users.noreply.github.com>
Changed M prefix to MS

Co-Authored-By: Luke Duddridge <338863+elduddz@users.noreply.github.com>
@elduddz elduddz merged commit 2e0a667 into namingconventions Aug 12, 2019
@elduddz elduddz deleted the namingconventions-add-networking-components branch August 12, 2019 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants