[LCS 406] Amend privacy policy & cookies headings #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sulthan-ahmed
commented
Jan 2, 2018
sulthan-ahmed
commented
- Make the heading larger
- open the privacy policy link in a new tab
- Make main heading be a h1 - Make the text a large heading. This has not been done for all h1s because h1s in other pages have a different styling
- This has been done in the way recommended by showdown showdownjs/showdown#337
sulthan-ahmed
commented
Jan 2, 2018
| @@ -1,4 +1,4 @@ | |||
| ## Cookies | |||
| # <div class='heading-large'> Cookies </div> | |||
There was a problem hiding this comment.
I had to wrap the class like this as it has a # for the markdown
sulthan-ahmed
commented
Jan 2, 2018
| @@ -1,3 +1,3 @@ | |||
| * you have informed the tenant that you will need to share their details with the Home Office for a right to rent check | |||
| * the information you’ve provided is correct to the best of your knowledge | |||
| * you have read and understood the [privacy policy](./privacy-policy) | |||
| * you have read and understood the <a href="./privacy-policy" target="_blank">privacy policy</a> | |||
There was a problem hiding this comment.
this is the recommended way to open a new tab in showdown
JoeChapman
approved these changes
Jan 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.