delete draft amendments #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joefitter
reviewed
Jul 10, 2019
joefitter
reviewed
Jul 10, 2019
|
I hate to be that guy but this PR is crying out for some unit tests 🏩 |
lennym
reviewed
Jul 11, 2019
lennym
reviewed
Jul 11, 2019
| @@ -139,8 +139,9 @@ describe('PIL resolver', () => { | |||
| .then(pil => { | |||
| assert.deepEqual(pil, undefined); | |||
| }) | |||
| .then(() => this.models.PIL.query()) | |||
| .then(() => this.models.PIL.queryWithDeleted().findById(opts.id)) | |||
There was a problem hiding this comment.
Is this just a fix for something else that's wildly out of scope?
There was a problem hiding this comment.
Yeah, this was returning an empty array before, which then passed the assertion even though there was no PIL.
lennym
reviewed
Jul 11, 2019
| @@ -165,8 +165,9 @@ describe('Place resolver', () => { | |||
| .then(place => { | |||
| assert.deepEqual(place, undefined); | |||
| }) | |||
| .then(() => this.models.Place.query()) | |||
| .then(() => this.models.Place.queryWithDeleted().findById(opts.id)) | |||
There was a problem hiding this comment.
Same deal here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.