Add stream module #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vinn946
commented
Mar 24, 2020
vinn946
commented
- adding nginx-mod-stream module
- update base alpine image
marcinc
reviewed
Mar 24, 2020
.drone.yml
Outdated
| @@ -8,7 +8,7 @@ pipeline: | |||
| - docker build -t nginx-test-img -f Dockerfile-test . | |||
| - docker run --name nginx-test -e NGINX_CONFIG_FILE=/nginx.conf -d nginx-test-img | |||
| - sleep 3 | |||
| - curl -sf http://$$(docker inspect -f '{{range .NetworkSettings.Networks}}{{.IPAddress}}{{end}}' nginx-test):10080 | |||
| - docker exec nginx-test curl -sf localhost:10080 | |||
There was a problem hiding this comment.
It this sufficiently testing the inclusion of mod-stream module?
vinn946
force-pushed
the
nginx-mod-stream
branch
from
98f0bc1
to
73b440a
Compare
marcinc
suggested changes
Mar 24, 2020
|
small comments. LGTM otherwise. |
vinn946
force-pushed
the
nginx-mod-stream
branch
from
73b440a
to
36b5396
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.