[LEVWEB-1173] Test full marriage details #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chimp, the acceptance testing module, has split into 2 versions: - `chimpy` the actively maintained old `chimp` - `chimp 2.0` a pipedream that doesn't exist
...with the other header inspection help.
...to explicitly check for the absence of fields from the full marriage view.
...to work correctly handle mixed case headers names - so not just `x-auth-username`, but `X-Auth-Username` now works too.
...for the `full-details` header that shows the complete marriage record.
daniel-ac-martin
requested changes
Jan 2, 2019
Providing an object that does not match the request info type object (i.e. a non-object, or one that does not contain the request info) will cause an error.
There was a problem hiding this comment.
Regarding the extra function, I don't think it really needs to be unit tested in isolation. It doesn't form part of the contract that that module makes with other modules and is only called in one place so unintended software regressions aren't an issue. I would just test it as a part of the main function but I'm not massively fussed.
...to be more generic (so that it now works with general headers as well as roles), and make funciton names a bit more descriptive.
daniel-ac-martin
approved these changes
Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a bunch of tests: unit, functional, acceptance... plus some [much needed] refactoring.
See individual commits for details...