Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in make_multilingual.py example after update in AdamW implementation #1782

Open
Lauler opened this issue Dec 5, 2022 · 0 comments
Open

Comments

@Lauler
Copy link

Lauler commented Dec 5, 2022

Hi,

This commit changing the AdamW implementation used from transformers to torch introduces an error in the example pretraining script make_multilingual.py.

In the transformers implementation there is an argument called correct_bias.

This argument doesn't exist in torch library's implementation: https://pytorch.org/docs/stable/generated/torch.optim.AdamW.html .

Can be fixed by just removing correct_bias from the dict passed to optimizer_params.
https://github.com/UKPLab/sentence-transformers/blob/master/examples/training/multilingual/make_multilingual.py#L220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant