-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #20
Update README.md #20
Conversation
added preliminary Matlab client
added Matlab client
added modified Matlab client and corresponding documentation |
Seems like you currently have two clients in clients/matlab. Only one of them is executed in automated testing via testing/clients/TestMatlab.m, so I believe one of them should be removed. Apart from that, looks good! |
changed client, connecting to a posterior model
changed Matlab client to posterior
added model evaluation with config
changed matlab client, model evaluation with config
I changed the file matlab_client.m. It uses a posterior model now, with configuration as well (should this be tested too?). So I think one can delete the matlabClient.m file and replace it with this one. |
You can add your branch to .github/workflows/client-matlab.yml to invoke the CI tests on every push of your branch, in addition to main. You can then test your edits without pull requests. In particular, it looks like either matlab_client.m should be renamed, or TestMatlab.m should be updated to run the new file. |
@marlenaweidenauer sounds good! You can make these changes yourself on your branch here. Probably won't work through the github website though, so you'll have to go with git from the command line. Let me know if you run into issues! |
fixed link
added repository
changed image to analytic funnel
changed value corresponding to analytic funnel
added test jacobian function
added documentation of Julia client
Pull request to update my branch
Looks good, thanks a lot! :) |
added preliminary Matlab client