Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #20

Merged
merged 19 commits into from
Oct 10, 2023
Merged

Update README.md #20

merged 19 commits into from
Oct 10, 2023

Conversation

marlenaweidenauer
Copy link
Collaborator

added preliminary Matlab client

added preliminary Matlab client
added Matlab client
@marlenaweidenauer
Copy link
Collaborator Author

added modified Matlab client and corresponding documentation

@linusseelinger
Copy link
Member

Seems like you currently have two clients in clients/matlab. Only one of them is executed in automated testing via testing/clients/TestMatlab.m, so I believe one of them should be removed. Apart from that, looks good!

changed client, connecting to a posterior model
changed Matlab client to posterior
added model evaluation with config
changed matlab client, model evaluation with config
@marlenaweidenauer
Copy link
Collaborator Author

I changed the file matlab_client.m. It uses a posterior model now, with configuration as well (should this be tested too?). So I think one can delete the matlabClient.m file and replace it with this one.
I changed the corresponding README aswell.

@dolgov
Copy link
Collaborator

dolgov commented Sep 6, 2023

You can add your branch to .github/workflows/client-matlab.yml to invoke the CI tests on every push of your branch, in addition to main. You can then test your edits without pull requests. In particular, it looks like either matlab_client.m should be renamed, or TestMatlab.m should be updated to run the new file.

@linusseelinger
Copy link
Member

@marlenaweidenauer sounds good! You can make these changes yourself on your branch here. Probably won't work through the github website though, so you'll have to go with git from the command line. Let me know if you run into issues!

@linusseelinger linusseelinger merged commit 513c957 into main Oct 10, 2023
@linusseelinger
Copy link
Member

Looks good, thanks a lot! :)

@marlenaweidenauer marlenaweidenauer deleted the marlenaweidenauer-patch-2 branch December 6, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants