Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matlab webwrite can be much faster than http.send. #21

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

dolgov
Copy link
Collaborator

@dolgov dolgov commented Aug 17, 2023

ttClient for benchmark-analytic-banana:
44.138067 seconds with 'send' http engine
4.250689 seconds with 'webwrite' http engine

As a by-product, tidy up http request code into one send_data function.

However, ttClient and constructor are defaulted to the old 'send' engine for CI & debugging. The issue with webwrite is that it flags all non-OK http statuses as errors, preventing differentiation between 'true' http errors and umbridge (model) errors.

@linusseelinger
Copy link
Member

Thanks a lot @dolgov ! This is a remarkable speedup!

@linusseelinger linusseelinger merged commit a8d86ab into main Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants