Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for model specific job submission scripts #64

Merged

Conversation

Schlevidon
Copy link
Collaborator

Added support for model specific job submission scripts:

  • HQ job submissions now use hq_scripts/job_<model_name>.sh if such a file exists and hq_scripts/job.sh as a default otherwise.
  • There is an option to always use the default job script, which is currently only used by the initial HQ job that determines the available models.
    • Therefore, the default hq_scripts/job.sh file is still always required! ⚠️
    • The load balancer will throw an exception if the default hq_script/job.sh file doesn't exist.

Possible issues:

  • There is currently no protection against typos in the name of a model specific job submission script. ⚠️
    • Could add console output whenever a fallback to the default job submission script occurs. However, this would clutter the output a lot.
    • Best solution would probably be to add proper logging, but that would be a bigger project (not a priority at the moment).

Copy link
Member

@linusseelinger linusseelinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
What do you think about the empty string model name point?

hpc/LoadBalancer.cpp Show resolved Hide resolved
@linusseelinger linusseelinger merged commit 1b151bb into main Mar 8, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants