Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add USTONKS-0921 price identifier #329

Merged
merged 8 commits into from Jun 22, 2021
Merged

Add USTONKS-0921 price identifier #329

merged 8 commits into from Jun 22, 2021

Conversation

rossgalloway
Copy link
Contributor

New UMIP for uSTONKS-0921 with a new basket of tickers.

Comments and questions:

  • The linked spreadsheet should start working once the feed from googlefinance updates. That may be on 6/16/2021.
  • Should this PID (and the contract) be 6 decimals to match USDC?
  • The price feed implementation link on line 58 is for uniswap. We will be pooling liquidity on sushiswap. Is there a different implementation for sushiswap?

Reinis-FRP
Reinis-FRP reviewed Jun 17, 2021
View reviewed changes
UMIPs/UMIP add uStonks-0921.md Outdated Show resolved Hide resolved
UMIPs/UMIP add uStonks-0921.md Outdated Show resolved Hide resolved
UMIPs/UMIP add uStonks-0921.md Outdated Show resolved Hide resolved
UMIPs/UMIP add uStonks-0921.md Outdated Show resolved Hide resolved
UMIPs/UMIP add uStonks-0921.md Outdated Show resolved Hide resolved
UMIPs/UMIP add uStonks-0921.md Show resolved Hide resolved
therealhexi
therealhexi approved these changes Jun 18, 2021
View reviewed changes
Copy link

@therealhexi therealhexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to community reviewer

@mhairimca mhairimca requested a review from smb2796 June 18, 2021 14:27
smb2796
smb2796 approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@smb2796 smb2796 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Merging in and moving to Last Call

@smb2796 smb2796 merged commit 8a2d4e6 into UMAprotocol:master Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhairimca mhairimca mhairimca left review comments

@Reinis-FRP Reinis-FRP Reinis-FRP left review comments

@therealhexi therealhexi therealhexi approved these changes

@smb2796 smb2796 smb2796 approved these changes

@CarelessDoge CarelessDoge CarelessDoge approved these changes

@chrismaree chrismaree Awaiting requested review from chrismaree

@pemulis pemulis Awaiting requested review from pemulis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rossgalloway @mhairimca @therealhexi @smb2796 @Reinis-FRP @CarelessDoge