M-03 [Oval] Newest Prices May Be Reported Ignoring the lockWindow() C…

…onstraint (#17) Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
UMAprotocol · Jun 18, 2024 · 2aa2c7d · 2aa2c7d
1 parent bce772d
commit 2aa2c7d
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/src/controllers/ImmutableController.sol b/src/controllers/ImmutableController.sol
@@ -18,6 +18,9 @@ abstract contract ImmutableController is Oval {
     mapping(address => bool) public unlockers;
 
     constructor(uint256 _lockWindow, uint256 _maxTraversal, address[] memory _unlockers, uint256 _maxAge) {
+        require(_maxAge > _lockWindow, "Max age not above lock window");
+        require(_maxTraversal > 0, "Max traversal must be > 0");
+
         LOCK_WINDOW = _lockWindow;
         MAX_TRAVERSAL = _maxTraversal;
         MAX_AGE = _maxAge;

diff --git a/src/controllers/MutableUnlockersController.sol b/src/controllers/MutableUnlockersController.sol
@@ -16,6 +16,9 @@ abstract contract MutableUnlockersController is Ownable, Oval {
     mapping(address => bool) public unlockers;
 
     constructor(uint256 _lockWindow, uint256 _maxTraversal, address[] memory _unlockers, uint256 _maxAge) {
+        require(_maxAge > _lockWindow, "Max age not above lock window");
+        require(_maxTraversal > 0, "Max traversal must be > 0");
+
         LOCK_WINDOW = _lockWindow;
         MAX_TRAVERSAL = _maxTraversal;
         MAX_AGE = _maxAge;

diff --git a/src/factories/BaseFactory.sol b/src/factories/BaseFactory.sol
@@ -24,6 +24,8 @@ contract BaseFactory is Ownable {
     );
 
     constructor(uint256 _maxTraversal, address[] memory _defaultUnlockers) {
+        require(_maxTraversal > 0, "Max traversal must be > 0");
+
         MAX_TRAVERSAL = _maxTraversal;
         setDefaultUnlockers(_defaultUnlockers);
     }