underscores

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>
UMAprotocol · May 20, 2024 · 55849cc · 55849cc
1 parent e032d3d
commit 55849cc
Show file tree

Hide file tree

Showing 5 changed files with 28 additions and 22 deletions.
diff --git a/src/factories/BaseFactory.sol b/src/factories/BaseFactory.sol
@@ -23,8 +23,8 @@ contract BaseFactory is Ownable {
         address[] unlockers
     );
 
-    constructor(uint256 maxTraversal, address[] memory _defaultUnlockers) {
-        MAX_TRAVERSAL = maxTraversal;
+    constructor(uint256 _maxTraversal, address[] memory _defaultUnlockers) {
+        MAX_TRAVERSAL = _maxTraversal;
         setDefaultUnlockers(_defaultUnlockers);
     }
 

diff --git a/src/factories/StandardChainlinkFactory.sol b/src/factories/StandardChainlinkFactory.sol
@@ -35,8 +35,8 @@ contract OvalChainlink is MutableUnlockersController, ChainlinkSourceAdapter, Ch
  * mutability choices are desired.
  */
 contract StandardChainlinkFactory is Ownable, BaseFactory {
-    constructor(uint256 maxTraversal, address[] memory _defaultUnlockers)
-        BaseFactory(maxTraversal, _defaultUnlockers)
+    constructor(uint256 _maxTraversal, address[] memory _defaultUnlockers)
+        BaseFactory(_maxTraversal, _defaultUnlockers)
     {}
 
     /**

diff --git a/src/factories/StandardChronicleFactory.sol b/src/factories/StandardChronicleFactory.sol
@@ -14,12 +14,18 @@ import {IMedian} from "../interfaces/chronicle/IMedian.sol";
  * Chronicle price feeds and allow usage via the Chainlink interface.
  */
 contract OvalChronicle is MutableUnlockersController, ChronicleMedianSourceAdapter, ChainlinkDestinationAdapter {
-    constructor(IMedian source, address[] memory unlockers, uint256 lockWindow, uint256 maxTraversal, address owner)
-        ChronicleMedianSourceAdapter(source)
-        MutableUnlockersController(lockWindow, maxTraversal, unlockers)
+    constructor(
+        IMedian _source,
+        address[] memory _unlockers,
+        uint256 _lockWindow,
+        uint256 _maxTraversal,
+        address _owner
+    )
+        ChronicleMedianSourceAdapter(_source)
+        MutableUnlockersController(_lockWindow, _maxTraversal, _unlockers)
         ChainlinkDestinationAdapter(18)
     {
-        _transferOwnership(owner);
+        _transferOwnership(_owner);
     }
 }
 

diff --git a/src/factories/StandardCoinbaseFactory.sol b/src/factories/StandardCoinbaseFactory.sol
@@ -14,18 +14,18 @@ import {BaseFactory} from "./BaseFactory.sol";
  */
 contract OvalCoinbase is MutableUnlockersController, CoinbaseSourceAdapter, ChainlinkDestinationAdapter {
     constructor(
-        IAggregatorV3SourceCoinbase source,
-        string memory ticker,
-        address[] memory unlockers,
-        uint256 lockWindow,
-        uint256 maxTraversal,
-        address owner
+        IAggregatorV3SourceCoinbase _source,
+        string memory _ticker,
+        address[] memory _unlockers,
+        uint256 _lockWindow,
+        uint256 _maxTraversal,
+        address _owner
     )
-        CoinbaseSourceAdapter(source, ticker)
-        MutableUnlockersController(lockWindow, maxTraversal, unlockers)
+        CoinbaseSourceAdapter(_source, _ticker)
+        MutableUnlockersController(_lockWindow, _maxTraversal, _unlockers)
         ChainlinkDestinationAdapter(18)
     {
-        _transferOwnership(owner);
+        _transferOwnership(_owner);
     }
 }
 
@@ -38,10 +38,10 @@ contract OvalCoinbase is MutableUnlockersController, CoinbaseSourceAdapter, Chai
 contract StandardCoinbaseFactory is Ownable, BaseFactory {
     IAggregatorV3SourceCoinbase immutable SOURCE;
 
-    constructor(IAggregatorV3SourceCoinbase source, uint256 maxTraversal, address[] memory _defaultUnlockers)
-        BaseFactory(maxTraversal, _defaultUnlockers)
+    constructor(IAggregatorV3SourceCoinbase _source, uint256 _maxTraversal, address[] memory _defaultUnlockers)
+        BaseFactory(_maxTraversal, _defaultUnlockers)
     {
-        SOURCE = source;
+        SOURCE = _source;
     }
 
     /**

diff --git a/src/factories/StandardPythFactory.sol b/src/factories/StandardPythFactory.sol
@@ -39,8 +39,8 @@ contract OvalPyth is MutableUnlockersController, PythSourceAdapter, ChainlinkDes
 contract StandardPythFactory is Ownable, BaseFactory {
     IPyth immutable pyth;
 
-    constructor(IPyth _pyth, uint256 maxTraversal, address[] memory _defaultUnlockers)
-        BaseFactory(maxTraversal, _defaultUnlockers)
+    constructor(IPyth _pyth, uint256 _maxTraversal, address[] memory _defaultUnlockers)
+        BaseFactory(_maxTraversal, _defaultUnlockers)
     {
         pyth = _pyth;
     }