L-06 [Oval] CoinbaseSourceAdapter May Return Old Prices (#24)

Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
UMAprotocol · Jun 18, 2024 · 70e5b66 · 70e5b66
1 parent 77e5441
commit 70e5b66
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/adapters/source-adapters/CoinbaseSourceAdapter.sol b/src/adapters/source-adapters/CoinbaseSourceAdapter.sol
@@ -83,8 +83,8 @@ abstract contract CoinbaseSourceAdapter is DiamondRootOval {
         // Attempt traversing historical round data backwards from roundId.
         (int256 historicalAnswer, uint256 historicalUpdatedAt) = _searchRoundDataAt(timestamp, roundId, maxTraversal);
 
-        // Validate returned data. If it is uninitialized, fall back to returning the current latest round data.
-        if (historicalUpdatedAt > 0) {
+        // Validate returned data. If it is uninitialized or too old, fall back to returning the current latest round data.
+        if (historicalUpdatedAt > block.timestamp - maxAge()) {
             return (historicalAnswer, historicalUpdatedAt);
         }