feat: fixes

Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
UMAprotocol · May 14, 2024 · fcf0c8b · fcf0c8b
1 parent addf0a9
commit fcf0c8b
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 3 deletions.
diff --git a/src/adapters/source-adapters/CoinbaseOracleSourceAdapter.sol b/src/adapters/source-adapters/CoinbaseOracleSourceAdapter.sol
@@ -4,7 +4,6 @@ pragma solidity 0.8.17;
 import {DecimalLib} from "../lib/DecimalLib.sol";
 import {IAggregatorV3Source} from "../../interfaces/chainlink/IAggregatorV3Source.sol";
 import {DiamondRootOval} from "../../DiamondRootOval.sol";
-import {console} from "forge-std/console.sol";
 
 /**
  * @title CoinbaseOracleSourceAdapter contract to read data from CoinbaseOracle and standardize it for Oval.

diff --git a/src/oracles/CoinbaseOracle.sol b/src/oracles/CoinbaseOracle.sol
@@ -65,7 +65,7 @@ contract CoinbaseOracle is IAggregatorV3Source {
     }
 
     // Internal function to recover the signer of a message
-    function recoverSigner(bytes memory message, bytes memory signature) public pure returns (address) {
+    function recoverSigner(bytes memory message, bytes memory signature) internal pure returns (address) {
         (bytes32 r, bytes32 s, uint8 v) = abi.decode(signature, (bytes32, bytes32, uint8));
         bytes32 hash = keccak256(abi.encodePacked("\x19Ethereum Signed Message:\n32", keccak256(message)));
         return ecrecover(hash, v, r, s);

diff --git a/test/unit/CoinbaseOracleSourceAdapter.sol b/test/unit/CoinbaseOracleSourceAdapter.sol
@@ -2,7 +2,6 @@
 pragma solidity 0.8.17;
 
 import {CommonTest} from "../Common.sol";
-import {console} from "forge-std/console.sol";
 
 import {BaseController} from "../../src/controllers/BaseController.sol";
 import {CoinbaseOracleSourceAdapter} from "../../src/adapters/source-adapters/CoinbaseOracleSourceAdapter.sol";