feat: add audited contracts #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Rice <matthewcrice32@gmail.com>
Reinis-FRP
approved these changes
May 16, 2024
| @@ -0,0 +1,46 @@ | |||
| // SPDX-License-Identifier: AGPL-3.0-only | |||
There was a problem hiding this comment.
do we want mixing licenses? this repo currently has BUSL-1.1
There was a problem hiding this comment.
@Reinis-FRP you're right. it should be the same license that this repo currently has.
| /** | ||
| * @notice ChronicleMedianDestinationAdapter contract to expose Oval data via the standard Chronicle interface. | ||
| */ | ||
|
|
There was a problem hiding this comment.
nit: forge fmt would remove empty line here and everywhere else after the contract NatSpec
Signed-off-by: chrismaree <christopher.maree@gmail.com>
chrismaree
approved these changes
May 16, 2024
mrice32
added a commit
that referenced
this pull request
May 20, 2024
Co-authored-by: chrismaree <christopher.maree@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds previously audited contracts to this repository.
Note: to move these over, I had to do a find/replace OVAL -> Oval. After that, the compilation seemed to work, but there may be other issues. If you notice something off, let me know and I can fix.