Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin foundry version #7

Merged
merged 2 commits into from
May 10, 2024
Merged

Conversation

Reinis-FRP
Copy link
Collaborator

Foundry upgrades have changed how contract state is persisted between rolled forks and oval tests fail to work on the latest foundry versions. This fix pins foundry to the last known compatible Nightly (2024-03-02) version.

Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
@Reinis-FRP Reinis-FRP requested review from mrice32 and md0x May 9, 2024 13:59
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Copy link
Collaborator

@md0x md0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Reinis-FRP Reinis-FRP merged commit dfd27ac into master May 10, 2024
3 checks passed
@Reinis-FRP Reinis-FRP deleted the reinis-frp/fix-foundry-version branch May 10, 2024 06:46
mrice32 pushed a commit that referenced this pull request May 16, 2024
* fix: source round detection

Signed-off-by: Reinis Martinsons <reinis@umaproject.org>

* feat: implement round updates in mean adapter

Signed-off-by: Reinis Martinsons <reinis@umaproject.org>

* feat: add delayed source data

Signed-off-by: Reinis Martinsons <reinis@umaproject.org>

* feat: add todos

Signed-off-by: Reinis Martinsons <reinis@umaproject.org>

* feat: chainlink round traversal

Signed-off-by: Reinis Martinsons <reinis@umaproject.org>

* fix: remove latest round

Signed-off-by: Reinis Martinsons <reinis@umaproject.org>

* fix: remove latest round from mock

Signed-off-by: Reinis Martinsons <reinis@umaproject.org>

* fix: internal function naming

Signed-off-by: Reinis Martinsons <reinis@umaproject.org>

* fix: return round data

Signed-off-by: Reinis Martinsons <reinis@umaproject.org>

* fix: comments

Signed-off-by: Reinis Martinsons <reinis@umaproject.org>

* fix: return latest in source if no historical data

Signed-off-by: Reinis Martinsons <reinis@umaproject.org>

* fix: add comment on updated at

Signed-off-by: Reinis Martinsons <reinis@umaproject.org>

* feat: move all permission window logic to oev

Signed-off-by: Reinis Martinsons <reinis@umaproject.org>

* feat: pass max traversal from oev

Signed-off-by: Reinis Martinsons <reinis@umaproject.org>

---------

Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants