fix[OA-audit-L01]: Limit ability for Full Policy Escalation Manager t…

…o setArbitrationResolution (#4319) * fix: Limit ability for Full Policy EscilationManager to setArbitrationResolution Signed-off-by: chrismaree <christopher.maree@gmail.com> * fix Signed-off-by: chrismaree <christopher.maree@gmail.com> * Update packages/core/test/foundry/optimistic-asserter/escalation-manager/FullPolicyEscalationManager.t.sol Signed-off-by: chrismaree <christopher.maree@gmail.com> Signed-off-by: Reinis Martinsons <reinis@umaproject.org> Co-authored-by: Reinis Martinsons <77973553+Reinis-FRP@users.noreply.github.com> Co-authored-by: Reinis Martinsons <reinis@umaproject.org>
UMAprotocol · Dec 22, 2022 · 76bed2a · 76bed2a
1 parent 97be5e6
commit 76bed2a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/...cts/optimistic-asserter/implementation/escalation-manager/FullPolicyEscalationManager.sol b/...cts/optimistic-asserter/implementation/escalation-manager/FullPolicyEscalationManager.sol
@@ -154,6 +154,7 @@ contract FullPolicyEscalationManager is BaseEscalationManager, Ownable {
         bool arbitrationResolution
     ) public onlyOwner {
         bytes32 requestId = getRequestId(identifier, time, ancillaryData);
+        require(arbitrationResolutions[requestId].valueSet == false, "Arbitration already resolved");
         arbitrationResolutions[requestId] = ArbitrationResolution(true, arbitrationResolution);
         emit ArbitrationResolutionSet(identifier, time, ancillaryData, arbitrationResolution);
     }

diff --git a/...ore/test/foundry/optimistic-asserter/escalation-manager/FullPolicyEscalationManager.t.sol b/...ore/test/foundry/optimistic-asserter/escalation-manager/FullPolicyEscalationManager.t.sol
@@ -18,13 +18,16 @@ contract FullPolicyEscalationManagerTest is CommonOptimisticAsserterTest {
         bytes memory ancillaryData = "ancillary";
 
         vm.expectRevert("Arbitration resolution not set");
-        escalationManager.getPrice(identifier, time, ancillaryData);
 
+        escalationManager.getPrice(identifier, time, ancillaryData);
         escalationManager.setArbitrationResolution(identifier, time, ancillaryData, true);
         assertTrue(escalationManager.getPrice(identifier, time, ancillaryData) == 1e18);
 
+        vm.expectRevert("Arbitration already resolved"); // Can not re-set the resolution price once set.
         escalationManager.setArbitrationResolution(identifier, time, ancillaryData, false);
-        assertTrue(escalationManager.getPrice(identifier, time, ancillaryData) == 0);
+
+        escalationManager.setArbitrationResolution(identifier, time + 1, ancillaryData, false); // Can set for new time.
+        assertTrue(escalationManager.getPrice(identifier, time + 1, ancillaryData) == 0);
     }
 
     function test_RevertIf_InvalidConfiguration() public {