Add events to MultiRole contract #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
ptare
reviewed
Apr 20, 2020
core/test/common/MultiRole.js
Outdated
| // Remove shared member. | ||
| const removeSharedResult = await multiRole.removeMember("2", account4, { from: account1 }); | ||
| truffleAssert.eventEmitted(removeSharedResult, "RemovedSharedMember", ev => { | ||
| return ev.roleId.toString() == "2", ev.oldMember == account4, ev.manager == account1; |
There was a problem hiding this comment.
What does the comma do here, as opposed to &&?
There was a problem hiding this comment.
Weird, that was produced via linting. I'm testing its behavior locally now
There was a problem hiding this comment.
Ah, this was not the linter's fault, it was my fault I accidentally replaced all &&'s with commas. Good catch @ptare
ptare
approved these changes
Apr 20, 2020
chrismaree
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1222
Signed-off-by: Nick Pai npai.nyc@gmail.com