fix(emp-contract): LiquidationWithdrawn settlementPrice emitted correctly. #1912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
daywiss
approved these changes
Aug 26, 2020
| @@ -1542,7 +1542,7 @@ contract("Liquidatable", function(accounts) { | |||
| // State should be uninitialized as the struct has been deleted as a result of the withdrawal. | |||
| // Once a dispute fails and the liquidator withdraws the struct is removed from state. | |||
| ev.liquidationStatus.toString() == LiquidationStatesEnum.UNINITIALIZED && | |||
| ev.settlementPrice.toString() == "0" | |||
There was a problem hiding this comment.
oh were these cases where the value was empty before
There was a problem hiding this comment.
Not empty but 0 because the struct was deleted. These tests were therefore false positives because we fixed the the RHS of the assert.equal to match the (unexpected) 0 price
There was a problem hiding this comment.
These should be using JavaScript triple equals
There was a problem hiding this comment.
Yeah they all should good catch
|
@nicholaspai don't forget to request reviewers! |
nicholaspai
requested review from
a team,
kendricktan and
mrice32
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nick Pai npai.nyc@gmail.com
Motivation
#1911
Summary
Store
settlementPricein intermediate var.Issue(s)
Fixes #1911