fix(dec-2020-audit): [N10] Unnecessary type cast #2316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Maree <christopher.maree@gmail.com>
Signed-off-by: Christopher Maree <christopher.maree@gmail.com>
chrismaree
added
the
dec-2020-audit
mrice32
reviewed
Dec 17, 2020
| @@ -87,9 +87,9 @@ contract ExpiringMultiPartyCreator is ContractCreator, Testable, Lockable { | |||
|
|
|||
| _registerContract(new address[](0), address(derivative)); | |||
There was a problem hiding this comment.
Should we remove the cast on this line as well?
| @@ -99,9 +99,9 @@ contract PerpetualCreator is ContractCreator, Testable, Lockable { | |||
|
|
|||
| _registerContract(new address[](0), address(derivative)); | |||
Signed-off-by: Christopher Maree <christopher.maree@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem identified in audit:
In lines 102 and 104 of PerpetualCreator.sol the derivative variable is cast to the address type. Since it is defined as address type, the casts are unnecessary.
Solution in this PR
The redundant type casting was removed. This change was also made to the EMP creator, which was not audited but the change was made for consistency.