New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Directory Reorg to incorporate v1 contracts #387
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if some of the price fetch stuff from PublishPriceFeed.js, such as the querying barchart part, belongs in common/? We could always refactor that out when we need to also, just a thought.
"max-states-count": false | ||
"max-states-count": false, | ||
"no-simple-event-func-name": false, | ||
"function-max-lines": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could/should we file a tech debt bug to bring these checks back?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #389.
As discussed IRL, I think we should just move more scripts over to |
Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com>
* Version bump (#375) Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * Fees fix (#379) * updated financials table to incl fees * Fixes #371 * forgot prettier again Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * MultiRole Contract (#380) Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * WIP Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * Fix typo in a comment in MultiRoleTest (#386) Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * Directory Reorg to incorporate v1 contracts (#387) Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * Add Finder contract that looks up implementations of interfaces (#388) Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * Emit an event when an interface address changes (#391) Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * Fix publishPrices.sh to not automatically provide keys (#394) Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * Fix BN operations in PublishPrices.js (#396) Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * Add basic implementation to commit votes (#393) Parts of this implementation will have to change when prices can actually be requested and when results can actually be computed. Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * Add Voting contract to migrations (#399) As discussed offline, we may want to rename the contract Voting.sol to something like Oracle.sol, DecentralizedOracle.sol, v2Oracle.sol, etc. Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * Add basic API and placeholder implementation of fixed point library (#401) See comments for some cases that aren't handled. Explicitly declaring a fixed point uint as the Unsigned type helps with readability. It's also helpful to bury all this functionality in a common place, where we can add more specialized methods or improve these computations as needed. Issue #351 Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * rebase Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * Bugfix, need a couple of awaits in unit test (#406) Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * WIP Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * WIP Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * WIP Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * Delete 2_deploy_store.js Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * Add mixed operations to fixed point library for uints (#404) Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * Add UMA token contract (#408) This token uses OpenZeppelin's ERC20Snapshot implementation for snapshotting. It further allows a given address to mint or burn tokens. I had to remove uninitialized-state-variables Slither detector because it falsely fires on OpenZeppelin's ERC20Snapshot contract. Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * Update solidity-coverage Updated to the new solidity-coverage beta version now that it's being updated again. This should fix our parsing issues seen in #409 and allow us to remove some of the hacky patching that was being done before. Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * WIP Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * Copy over Registry contract and use MultiRole (#409) I went back and forth on whether to manage approved derivative creators via a MultiRole or keep what v0/Registry.sol did. Here's what it would look using MultiRole, let me know if you prefer another way. It might be easiest to look at commit 1683dbb, which contains the actual changes from v0/contracts/Registry.sol. Further improvements that we could make to the Registry in either this PR or in follow up PRs: Remove PointerValidity enum Add formatted documentation Add to migrations Issue #409 Needed a weird workaround for getting the coverage tool to work. Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * Basic Price Requests (#402) Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * WIP Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * Slight improvements to Registry (#412) Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * WIP Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * WIP Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * Add Finder contract to migration (#416) Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * Store calculates regular and final fees Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * cleaned up Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * Add ResultComputation library based on mode computation (#415) Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * Don't estimate #tokens that can be created if no underlying price (#419) Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * fixed import issue hopefully Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * Delete 3_deploy_store.js Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * more cleanup Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * addressing slither Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * more slither fixes Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * more slither Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * ok even more slither updates Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * Readme Updates (#414) Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * Copy node_modules over when running Slither (#426) Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * Add a backup Infura API key (#431) Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * added governance permissioning and fixed point numbers Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * prettier etc Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * Rename v1/ to core/ and remove v0/ from CI (#437) Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * addressing linter Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * added weird method for coverage issue Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * more coverage issues Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * Move Testable into core/contracts from common/contracts (#439) Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * Disable DCO for members of UMA team (#440) * WIP Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * remove DCO requirement for members of UMA Signed-off-by: Matthew Rice <matthewcrice32@gmail.com> Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * Add functions to enable computing rewards (#420) Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * addressed comment issues, separated tests Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * forgot to clean up for ci as usual Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * very ugly rebase to get DCO working, should be resolved * removed weird duplicates Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * oops Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * finally removed FP converter Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * appeasing linter Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * comment cleanup * WIP Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * removed files causing conflicts Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * fixing up Store comments * store now implements withdrawable Signed-off-by: Roz Stengle <rosalind.stengle@gmail.com> * Revert "merge conflicts" This reverts commit 8a92b1b, reversing changes made to 8e88475.
This PR refactors the directory structure. As a part of that, much of our CI processes had to be refactored to handle two independent truffle directories.
The new directory structure looks like this:
v0
contains all contracts that existed before v1 work began and any scripts that were specific to that work.v1
contains the MultiRole contract, which is the only contract we've added as a part of the v1 work. This directory will hold all contracts and scripts that are specific to the v1 oracle work.common
contains any shared javascript files that are needed by bothv1
andv0
. We may eventually add Solidity contracts, tests, etc to this directory, but that may require giving it its ownpackage.json
file, making it an independent package. We won't do that unless we deem it necessary and worthwhile.sponsor-dapp
was left almost entirely unchanged.It was not necessary to give
v1
,v0
, orcommon
their ownpackage.json
files, so they are all built on the same set of dependencies. To run truffle commands,cd
into eitherv0
orv1
and it should work normally.Note: I realized that our solidity linter wasn't being run over all of our Solidity files, so that bug was fixed. Since the linter hadn't been running for a while, a few of our v0 contracts had to be modified to match the desired style.
TODO(mrice32): update README instructions to take the new directory structure into account.