fix: [L02]: Duplicate function execution in commitAndEmitEncryptedVote

[chrismaree]

Motivation

OZ identified the following issue:

In the VotingV2 contract the overloaded function commitAndEmitEncryptedVote that is
provided for backwards compatibility mistakenly calls commitVote twice: The first call to
commitVote is performed directly within the function body on line 614, and an additional call
is performed indirectly by the call to commitAndEmitEncryptedVote on line 616.
The duplicate call is an unnecessary gas expense and leads to an unintentional duplication of
VoteCommitted event emission.

Fix presented in this PR:

Remove the duplicate call to commitVote.

Testing

Check a box to describe how you tested these changes and list the steps for reviewers to test.

• Ran end-to-end test, running the code as in production
• New unit tests created
• Existing tests adequate, no new tests required
• All existing tests pass
• Untested

[mrice32]

LGTM once extra changes are removed!

[mrice32]

nit: I think changes from #4068 were accidentally included. We should probably drop this commit.

[mrice32]

Wow, this is a great catch!

[md0x]

Nice catch. LGTM