Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [post-audit-feedback]: Address typos and small issues identified before getting full audit feedback #4178

Merged
merged 1 commit into from Sep 20, 2022
Merged

fix: [post-audit-feedback]: Address typos and small issues identified before getting full audit feedback #4178

merged 1 commit into from Sep 20, 2022

Conversation

chrismaree
Copy link
Member

Motivation

OZ identified the following issues before providing the final audit feedback:

small typo in #4151 - "cant"
Also in #4159 it looks like VotingUpgrader.sol was changed instead of VotingUpgraderV2.sol
In #4152 there is still an issue with the line "Addresses to upgrade..." b/c it says "addresses" plural, not "address" singular

This PR addresses the 3 issues identified.

@chrismaree
fix: [post-audit-feedback]: Address typos and small issues identified…
3be4710 
… before getting full audit feedback

Signed-off-by: chrismaree <christopher.maree@gmail.com>
@chrismaree chrismaree merged commit 408ec25 into master Sep 20, 2022
@chrismaree chrismaree deleted the chrismaree/fix-identified-audit-issues branch September 20, 2022 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrice32 mrice32 mrice32 approved these changes

@nicholaspai nicholaspai Awaiting requested review from nicholaspai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chrismaree @mrice32