fix[OA-audit-N08]: Fix address multicaller payability #4327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chrismaree <christopher.maree@gmail.com>
chrismaree
requested review from
mrice32,
nicholaspai,
md0x and
Reinis-FRP
as code owners
Reinis-FRP
approved these changes
Dec 21, 2022
Reinis-FRP
approved these changes
Dec 21, 2022
Reinis-FRP
pushed a commit
that referenced
this pull request
Dec 28, 2022
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Reinis-FRP
added a commit
that referenced
this pull request
Jan 10, 2023
* feat: implement dvm v2 unstake monitor Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * feat: implement dvm v2 stake monitor Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * feat: implement dvm v2 proposal monitor Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * feat: implement dvm v2 deletion proposal monitor Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * feat: implement dvm v2 emergency proposal monitor Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * feat: implement dvm v2 rolled votes monitor Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix dvm monitor logger imports Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * feat: update dvm2.0 upgrade script (#4304) * feat: update dvm2.0 upgrade script Signed-off-by: Pablo Maldonado <pablo@umaproject.org> * feat: update starting index Signed-off-by: Pablo Maldonado <pablo@umaproject.org> * refactor: update comments Signed-off-by: Pablo Maldonado <pablo@umaproject.org> * feat: update starting index and starting id Signed-off-by: Pablo Maldonado <pablo@umaproject.org> * fix: governor starting id Signed-off-by: Pablo Maldonado <pablo@umaproject.org> * fix: add previous voting contracts events Signed-off-by: Pablo Maldonado <pablo@umaproject.org> * fix: add previous voting contracts events docs Signed-off-by: Pablo Maldonado <pablo@umaproject.org> * refator: improve comment Signed-off-by: Pablo Maldonado <pablo@umaproject.org> Signed-off-by: Pablo Maldonado <pablo@umaproject.org> Co-authored-by: Pablo Maldonado <pablo@umaproject.org> Co-authored-by: chrismaree <christopher.maree@gmail.com> Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: address issue in CI (#4315) Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * build(deps): bump decode-uri-component from 0.2.0 to 0.2.2 (#4301) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: chrismaree <christopher.maree@gmail.com> Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * chore: Bump ethers to 5.7.x in common and sdk (#4214) Co-authored-by: chrismaree <christopher.maree@gmail.com> Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * feat: add new health check runner package (#4311) Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * improve: Add MerkleTree improvements made in across-protocol/contracts-v2 (#4318) Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * feat: new release (#4322) * feat: new release Captures MerkleTree util change to match across-protocol/contracts-v2 * Update CHANGELOG.md * Update CHANGELOG.md * lint Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * feat: Add mainnet forking test case (#4306) Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix[OA-audit-L03]: Address erronous docstrings and comments (#4320) Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix[OA-audit-N04]: Add additional index paramaters (#4323) Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix[OA-audit-N05]: Address argument name mismatches between interface and implementation (#4324) Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix[OA-audit-N06]: Address Missing event parameter (#4325) Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix[OA-audit-N07]: Fix licencing issues accross the OA (#4326) Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix[OA-audit-N08]: Fix address multicaller payability (#4327) Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix[OA-audit-N09]: Missing check for non-zero address (#4336) Co-authored-by: Pablo Maldonado <pablo@umaproject.org> Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: use external functions in oa (#4337) Signed-off-by: Reinis Martinsons <reinis@umaproject.org> Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: remove unused import (#4338) Signed-off-by: Reinis Martinsons <reinis@umaproject.org> Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: dont use named return variables (#4341) Signed-off-by: Reinis Martinsons <reinis@umaproject.org> Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix[OA-audit-N10]: Fix redundant code (#4335) * fix: remove override from base em Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: shared getRequestId function in full policy em Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: simplify require in configureEscalationManager Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: simplify em lookup in oa Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: store callback recipients as local variables in oa Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: redundant return in oa Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: remove forge-std lib Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: add back gitmodules Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: add newline in gitmodules Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: newline in gitmodules Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: shorten variable names Signed-off-by: Reinis Martinsons <reinis@umaproject.org> Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix[OA-audit-N12]: Typographical errors (#4339) Signed-off-by: Pablo Maldonado <pablo@umaproject.org> Signed-off-by: Pablo Maldonado <pablo@umaproject.org> Signed-off-by: chrismaree <christopher.maree@gmail.com> Signed-off-by: Reinis Martinsons <reinis@umaproject.org> Co-authored-by: Pablo Maldonado <pablo@umaproject.org> Co-authored-by: chrismaree <christopher.maree@gmail.com> Co-authored-by: Reinis Martinsons <reinis@umaproject.org> Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix[OA-audit-L01]: Limit ability for Full Policy Escalation Manager to setArbitrationResolution (#4319) * fix: Limit ability for Full Policy EscilationManager to setArbitrationResolution Signed-off-by: chrismaree <christopher.maree@gmail.com> * fix Signed-off-by: chrismaree <christopher.maree@gmail.com> * Update packages/core/test/foundry/optimistic-asserter/escalation-manager/FullPolicyEscalationManager.t.sol Signed-off-by: chrismaree <christopher.maree@gmail.com> Signed-off-by: Reinis Martinsons <reinis@umaproject.org> Co-authored-by: Reinis Martinsons <77973553+Reinis-FRP@users.noreply.github.com> Co-authored-by: Reinis Martinsons <reinis@umaproject.org> Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix[OA-audit-L02]: Lack of access control (#4334) * fix[OA-audit-L02]: Lack of access control on potentially sensitive function Signed-off-by: Pablo Maldonado <pablo@umaproject.org> * test: test onlyOptimisticAsserter modifier Signed-off-by: Pablo Maldonado <pablo@umaproject.org> * fix Signed-off-by: chrismaree <christopher.maree@gmail.com> * Update packages/core/test/foundry/optimistic-asserter/escalation-manager/DisputeLimitingEscalationManager.t.sol Co-authored-by: Reinis Martinsons <77973553+Reinis-FRP@users.noreply.github.com> * Update packages/core/test/foundry/optimistic-asserter/escalation-manager/BaseEscalationManager.t.sol Co-authored-by: Reinis Martinsons <77973553+Reinis-FRP@users.noreply.github.com> * Update packages/core/test/foundry/optimistic-asserter/escalation-manager/DisputeLimitingEscalationManager.t.sol Co-authored-by: Reinis Martinsons <77973553+Reinis-FRP@users.noreply.github.com> * fix Signed-off-by: chrismaree <christopher.maree@gmail.com> * fix: remove Ownable from base em Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: reorder imports Signed-off-by: Reinis Martinsons <reinis@umaproject.org> Signed-off-by: Pablo Maldonado <pablo@umaproject.org> Signed-off-by: chrismaree <christopher.maree@gmail.com> Signed-off-by: Reinis Martinsons <reinis@umaproject.org> Co-authored-by: Pablo Maldonado <pablo@umaproject.org> Co-authored-by: chrismaree <christopher.maree@gmail.com> Co-authored-by: Reinis Martinsons <77973553+Reinis-FRP@users.noreply.github.com> Co-authored-by: Reinis Martinsons <reinis@umaproject.org> Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix[OA-audit-N15]: Use of magic numbers (#4340) Co-authored-by: Pablo Maldonado <pablo@umaproject.org> Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix[OA-audit-L04]: Add missing or incomplete docstrings (#4342) * fix: natspec in oa public methods Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: add docstrings to oa interface Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: add natspec to oa callback recipient interface Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: natspec in base em Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: natspec em interface Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: natspec full policy em Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: add comments to internal oa functions Signed-off-by: Reinis Martinsons <reinis@umaproject.org> Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix[OA-audit-N03]: Always send oracle fee to the Store (#4343) * fix: always pay oracle fee Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: lift zero fee check Signed-off-by: Reinis Martinsons <reinis@umaproject.org> Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * feat: refactor dmv monitoring to use single entry Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * feat: add readme Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: readme Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * feat: monitor governor transfers Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * feat: monitor uma mints Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: rename common file Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * Revert "fix: rename common file" This reverts commit e674408. Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * feat: rename dvm monitor Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: improve block update and add comments Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: add token units to readme Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: parse threshold parameters from main entry point Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: update block range only in main entry point Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: update log levels Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: typescript error Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * feat: use tsc Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: update readme Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: monitor bots after dvm refactor Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: Signed-off-by: Reinis Martinsons <reinis@umaproject.org> Signed-off-by: Reinis Martinsons <reinis@umaproject.org> Signed-off-by: Pablo Maldonado <pablo@umaproject.org> Signed-off-by: chrismaree <christopher.maree@gmail.com> Co-authored-by: Pablo Maldonado <pablomaldonadoturci@gmail.com> Co-authored-by: Pablo Maldonado <pablo@umaproject.org> Co-authored-by: chrismaree <christopher.maree@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: nicholaspai <9457025+nicholaspai@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
OZ identifies the following issue:
This PR updates the multicaller contract to remove both the require and the payable keyword.