fix(og): N-02 - Remove payable in executeProposal #4491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
chrismaree
reviewed
Mar 22, 2023
| @@ -297,7 +297,7 @@ contract OptimisticGovernor is OptimisticOracleV3CallbackRecipientInterface, Mod | |||
| * @notice Executes an approved proposal. | |||
| * @param _transactions the transactions being executed. These must exactly match those that were proposed. | |||
| */ | |||
| function executeProposal(Transaction[] memory _transactions) external payable nonReentrant { | |||
| function executeProposal(Transaction[] memory _transactions) external nonReentrant { | |||
There was a problem hiding this comment.
would the value passed in not be pulled out on exec with transaction.value?
There was a problem hiding this comment.
no, exec does not pass msg.value when calling execTransactionFromModule on the target (safe) here. The value parameter in execTransactionFromModule would pull Ether from the safe in case of regular call operation, but any value sent by the caller of executeProposal would be stuck in the Optimistic Governor contract.
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
chrismaree
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
OZ identified the following issue:
Summary
This PR addresses this issue by removing the payable attribute to avoid potentially locking ETH in the OptimisticGovernor contract.
Testing
Check a box to describe how you tested these changes and list the steps for reviewers to test.