Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(og): N-03 - Swap misleading variable names #4492

Merged
merged 2 commits into from Mar 22, 2023

Conversation

Reinis-FRP
Copy link
Contributor

Motivation

OZ identified the following issue:

The proposalHashes and assertionIds mapping names misleadingly reflect the
contents of one another (i.e., proposalHashes stores assertionId values, and
assertionIds stores proposalHash values).

Summary

This PR addresses this issue by swapping the names of the proposalHashes and assertionIds mappings, so that the variable names correspond to the values being stored.

Testing

Check a box to describe how you tested these changes and list the steps for reviewers to test.

  • Ran end-to-end test, running the code as in production
  • New unit tests created
  • Existing tests adequate, no new tests required
  • All existing tests pass
  • Untested

Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Copy link
Member

@mrice32 mrice32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah, this one is really weird. LGTM! These all look swapped correctly.

Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
@Reinis-FRP Reinis-FRP merged commit c1e996c into master Mar 22, 2023
1 check passed
@Reinis-FRP Reinis-FRP deleted the reinis-frp/n03-og-upgrade branch March 22, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants