Add expiry and settlement functions to ViewPositions button #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Rice <matthewcrice32@gmail.com>
mrice32
commented
Sep 18, 2019
| text: "Expire Contract", | ||
| handler: expireHandler | ||
| }; | ||
| } else if (isContractSponsor && !isApproved) { |
There was a problem hiding this comment.
@ptare one minor note here: Not sure if we should prefer showing the approval button or the expiry/settlement buttons if both actions are possible. Curious to hear your thoughts.
There was a problem hiding this comment.
Preferring settle and expire seem right to me. Even if we allow them to approve first, the dapp won't let them deposit or create tokens anyway because they can't get to the Manage Positions page.
ptare
approved these changes
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will effectively force the user to take settlement or expiry actions if possible before moving to the ManagePositions page.