Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submitted revised subgraph docs #6

Merged
merged 16 commits into from Aug 31, 2022
Merged

Submitted revised subgraph docs #6

merged 16 commits into from Aug 31, 2022

Conversation

PaulieB14
Copy link
Contributor

@smb2796 Added subgraph info, entities for Mainnet Voting and example queries.

@PaulieB14
Copy link
Contributor Author

@smb2796 I also added to summary.md as well

@smb2796 smb2796 requested review from pemulis, md0x and abg4 August 30, 2022 13:51
Signed-off-by: John Shutt <pemulis@users.noreply.github.com>
@pemulis
Copy link
Contributor

pemulis commented Aug 30, 2022

@PaulieB14 can you give me permission to push changes to your fork?

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

I'm doing some local editing to make it consistent with our house style and checking all of the details of the PR. If you give me permission to push to your fork I can push those updates as part of the same PR. :)

@PaulieB14
Copy link
Contributor Author

@pemulis sure I just added you now. Let me know if I need to do anything on my end

Signed-off-by: John Shutt <pemulis@users.noreply.github.com>
@pemulis
Copy link
Contributor

pemulis commented Aug 30, 2022

Overall looks great @PaulieB14, thanks for creating this! I pushed some changes to your fork, mainly around style consistency and fixing a few typos. I think we can look to get this merged (pending other reviews) and enhance from there.

@PaulieB14
Copy link
Contributor Author

PaulieB14 commented Aug 30, 2022

Awesome. Thank you!. Whatever I can do, let me know and I'll jump on it.

corrected explorer page
removed extra bracket
Copy link
Collaborator

@abg4 abg4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for submitting! I just had a few small changes.

resources/subgraphs/mainnet-voting-entities.md Outdated Show resolved Hide resolved
resources/subgraphs/mainnet-voting-entities.md Outdated Show resolved Hide resolved
resources/subgraphs/mainnet-voting-entities.md Outdated Show resolved Hide resolved
resources/subgraphs/subgraph-data.md Outdated Show resolved Hide resolved

[Creating an API Key Video Tutorial](https://www.youtube.com/watch?v=UrfIpm-Vlgs)

- [Explorer Page](https://thegraph.com/explorer/subgraph?id=FVmuv3TndQDNd2BWARV8Y27yuKKukryKXPzvAS5E7htC&view=Overview)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This points to juicebox. Could we update to an UMA Explorer Page?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed this on a commit

[Creating an API Key Video Tutorial](https://www.youtube.com/watch?v=UrfIpm-Vlgs)

- [Explorer Page](https://thegraph.com/explorer/subgraph?id=FVmuv3TndQDNd2BWARV8Y27yuKKukryKXPzvAS5E7htC&view=Overview)
- Graphql Endpoint: https://gateway.thegraph.com/api/[api-key]/subgraphs/id//41LCrgtCNBQyDiVVyZEuPxbvkBH9BxxLU3nEZst77V8o
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a broken link. Is an api-key needed to access?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The end point link is really to copy and paste into websites like https://graphiql-online.com/graphiql. When you plug in as end point it allows you to develope different queries for UMA

PaulieB14 and others added 4 commits August 30, 2022 14:20
Co-authored-by: abg4 <76416300+abg4@users.noreply.github.com>
Co-authored-by: abg4 <76416300+abg4@users.noreply.github.com>
Co-authored-by: abg4 <76416300+abg4@users.noreply.github.com>
Co-authored-by: abg4 <76416300+abg4@users.noreply.github.com>
@pemulis pemulis merged commit 12470da into UMAprotocol:master Aug 31, 2022
@PaulieB14
Copy link
Contributor Author

PaulieB14 commented Aug 31, 2022

@pemulis a couple entities didn't flow right on website - I did a quick PR to correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants