-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the GetValues class #18
Comments
Thanks, I'm also checking the code. |
@loganchen39 I think |
@mmiesch do you know what the plans are for adding the masking in @loganchen39 You can go ahead and start working on |
Ok,
…On 11/2/2020 7:32 PM, Travis Sluka wrote:
@mmiesch <https://github.com/mmiesch> do you know what the plans are
for adding the masking in |InterpolatorUnstructured|?
@loganchen39 <https://github.com/loganchen39> You can go ahead and
start working on |GetValues|. If we don't have masking by the end of
that work then we can just use nco/cdo to fill in the missing values
of the sst background to create an "aqua planet" for our tests. We'll
worry about masking later.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMUO2PEWVEBEB35A4KCGJH3SN5FQPANCNFSM4THV6QPQ>.
|
I wasn't aware of any plans but it would be pretty straightforward to do. I could create a ZenHub ticket. I personally would be unlikely to get to it in November but maybe December. Ot, others could do it sooner. |
note to self: https://github.com/JCSDA-internal/oops/issues/952 will be needed to properly finish our |
@travissluka How do we define the observation grid/functionSpace which will be needed for interpolation? I have uploaded the obs data we'll use to branch feature/GetValues, which has grid of 0.05x0.05 degree, i.e. 3600x7200. For each day it has 2 files for "day" and "night" respectively. Be aware if you use ncview to view the data, it will show almost all of the data are missing values, while actually it's not. Jim and I used to plot the data, and during early periods of 1980s, about 20%~30% are valid data. In this case the grid/FunctionSpace should be easy to define. I checked your "obs_sst.nc". Will we use it? How to define the Unstructured Grid that can be used for interpolation? Maybe we can have a discussion sometime. |
@loganchen39 those files should not be placed in this repository. The test data is intended to be small so that all the ctests run in just a couple of seconds. ioda/ufo handles all the loading of observations, so this isn't something you need to worry about. The locations of observations are provided by |
@travissluka Ok, I'll delete the raw SST files which are too big. I have following questions.
|
|
This class does the interpolation of
State
variables to observations locations, and passes it to UFO to run the forward operator.I need to check and see what the best way to do the interpolation is now (there are generic interpolation routines in OOPS that use SABER/BUMP... I'll try to track these down for you)
TestGetValues
should pass afterward.The text was updated successfully, but these errors were encountered: