Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove preserve-paths package #33

Merged
merged 6 commits into from
Jul 25, 2023
Merged

chore: remove preserve-paths package #33

merged 6 commits into from
Jul 25, 2023

Conversation

lazysoundsystem
Copy link
Contributor

Refs: OPS-9348

@github-actions
Copy link

github-actions bot commented Jul 3, 2023 •
edited
Loading

Build output

Composer Validate success

PHP Lint success

Docker Build success

Environment Setup success

Site Install success

PHP Code Sniffer success

Software Versions PHP 8.1.21 (cli) (built: Jul 8 2023 07:10:19) (NTS) Copyright (c) The PHP Group Zend Engine v4.1.21, Copyright (c) Zend Technologies with Zend OPcache v8.1.21, Copyright (c), by Zend Technologies with Xdebug v3.2.1, Copyright (c) 2002-2023, by Derick Rethans Composer version 2.5.8 2023-06-09 17:13:21
Drupal Logs

Pusher: @lazysoundsystem, Action: pull_request, Workflow: Run tests

orakili
orakili reviewed Jul 5, 2023
View reviewed changes
composer.json Outdated
"drupal/console-extend-plugin": true,
"drupal/core-composer-scaffold": true,
"drupal/core-project-message": true,
"oomphinc/composer-installers-extender": true,
"orakili/composer-drupal-info-file-patch-helper": true,
"phpstan/extension-installer": true,
"symfony/flex": true
"symfony/flex": true,
"drupal-composer/preserve-paths": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed if the plugin is being removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never worked out why composer wanted to put that line back in. I've removed it again and it seems okay with that now.

@github-actions
Copy link

Coverage Report

Totals Coverage

@lazysoundsystem lazysoundsystem merged commit 482b4c7 into main Jul 25, 2023
2 checks passed
@lazysoundsystem lazysoundsystem deleted the OPS-9348-preserve-paths branch July 25, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orakili orakili orakili approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@lazysoundsystem @orakili