Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPS-9227] Update local stack, composer, config and tests #49

Merged
merged 12 commits into from
Sep 20, 2023

Conversation

orakili
Copy link
Contributor

@orakili orakili commented Sep 16, 2023

Refs: OPS-9227

This does the following:

  1. Port the latest improvements to the local stack from Local Readme and settings.site.php.example  rwint9-site#647
  2. Update the Dockerfile to the latest standards
  3. Update the composer dependencies (except for social_auth_hid (https://www.drupal.org/i/3387441) and google_tag (OPS-9640))
  4. Update the local tests (to new "standard")

@github-actions
Copy link

Build output

Composer Validate success

PHP Lint success

Docker Build success

Environment Setup success

Site Install success

PHP Code Sniffer success

Software Versions PHP 8.2.10 (cli) (built: Sep 2 2023 06:59:22) (NTS) Copyright (c) The PHP Group Zend Engine v4.2.10, Copyright (c) Zend Technologies with Zend OPcache v8.2.10, Copyright (c), by Zend Technologies with Xdebug v3.2.1, Copyright (c) 2002-2023, by Derick Rethans Composer version 2.6.3 2023-09-15 09:38:21
Drupal Logs

Pusher: @orakili, Action: pull_request, Workflow: Run tests

COPY --from=builder /srv/www/vendor /srv/www/vendor/
COPY --from=builder /srv/www/assets /srv/www/assets
COPY --from=builder /srv/www/config /srv/www/config
COPY --from=builder /srv/www/config_dev /srv/www/config_dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is necessary, and removing it has helped with dev deployments in other sites.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to ensure the image has all the directories referenced in its config and composer files independently of what is mounted in the instance as it may vary per environment, setup etc.

Copy link
Contributor

@lazysoundsystem lazysoundsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@github-actions
Copy link

Coverage Report

Totals Coverage

@orakili orakili merged commit a584ce8 into develop Sep 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants