Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HYC-1882 - Dimensions Ingest Service #1095

Merged
merged 40 commits into from
Apr 24, 2024
Merged

HYC-1882 - Dimensions Ingest Service #1095

merged 40 commits into from
Apr 24, 2024

Conversation

davidcam-src
Copy link
Contributor

https://unclibrary.atlassian.net/browse/HYC-1882

  • Introducing class to process new publications from dimensions and add them to the existing repository as well as tests

@davidcam-src
starter code ingest service
f4f2a78
@davidcam-src
ingest service test
83dd358
@davidcam-src
publication attributes
48bf36d
@davidcam-src
article_with_metadata dimensions ingest
109ed6d
@davidcam-src
minor changes
688dd78
@davidcam-src
working on setting creators attributes for article retrieved from dim…
b1fe780 
…ensions
@davidcam-src
removing comments
d1d6bfc
@davidcam-src
impl mapping for article creator attributes
6b79530
@davidcam-src
funder mapping for dimensions ingest
5082363
@davidcam-src
changes for efficiency for funder mapping
5d71edb
@davidcam-src
Merge branch 'main' into hyc-1882-dimensions-ingest-service
5551614
@davidcam-src
adding abstract in dimensions api return fields, new test fixture, ma…
610da6d 
…pping for date, abstract, resource type and identifies
@davidcam-src
adding more return fields in dimensions api request, ingest mapping i…
f543037 
…n progess
@davidcam-src
rights statement, dcmi type and page mapping
57f8784
@davidcam-src
issn and edition mapping
51598ab
@davidcam-src
updates for readability, changing query service and test fixture
ccc66e7
@davidcam-src
adding pdfs to works, visibility and permissions attributes
9a68c07
@davidcam-src
moving some ingest functionality to a separate utility class
b7b8889
@davidcam-src
more stubbing for tests, modifying test fixture
a47c4ff
@davidcam-src
adding pds to newly ingested articles and cleanup for files created d…
b315389 
…uring the process
@davidcam-src
testing and error handling for extract pdf wip
702f177
@davidcam-src
more tests and error handling for extract pdf
c921eca
@davidcam-src
linting, some function changes
f36be07
@davidcam-src
new test for ingest_publications
f3226e4
@davidcam-src
small refactor
5b63679
@davidcam-src
initialize tests
4a711c3
@davidcam-src
linting, removing comments
3f4b5be
@davidcam-src
process publication tests
b441dd7
@davidcam-src
metadata test wip, addressing bug, changing test fixture
40995c6
@davidcam-src
tests for error handling
dd79844
bbpennel
bbpennel requested changes Apr 22, 2024
View reviewed changes
app/services/tasks/dimensions_ingest_service.rb Outdated Show resolved Hide resolved
app/services/tasks/dimensions_ingest_service.rb Outdated Show resolved Hide resolved
app/services/tasks/dimensions_ingest_service.rb Outdated Show resolved Hide resolved
app/services/tasks/dimensions_ingest_service.rb Outdated Show resolved Hide resolved
app/services/tasks/dimensions_ingest_service.rb Outdated Show resolved Hide resolved
spec/services/tasks/dimensions_ingest_service_spec.rb Outdated Show resolved Hide resolved
spec/services/tasks/dimensions_ingest_service_spec.rb Outdated Show resolved Hide resolved
spec/services/tasks/dimensions_ingest_service_spec.rb Outdated Show resolved Hide resolved
spec/services/tasks/dimensions_ingest_service_spec.rb Outdated Show resolved Hide resolved
spec/services/tasks/dimensions_ingest_service_spec.rb Outdated Show resolved Hide resolved
bbpennel
bbpennel requested changes Apr 24, 2024
View reviewed changes
app/services/tasks/dimensions_ingest_service.rb Outdated Show resolved Hide resolved
app/services/tasks/dimensions_ingest_service.rb Outdated Show resolved Hide resolved
app/services/tasks/dimensions_ingest_service.rb Outdated Show resolved Hide resolved
app/services/tasks/dimensions_ingest_service.rb Outdated Show resolved Hide resolved
@bbpennel bbpennel merged commit 127ff43 into main Apr 24, 2024
4 checks passed
@bbpennel bbpennel deleted the hyc-1882-dimensions-ingest-service branch April 24, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbpennel bbpennel bbpennel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidcam-src @bbpennel