Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HYC-1913 - Group sharing and visibility safeguards #6

Merged
merged 39 commits into from
May 9, 2024
Merged

HYC-1913 - Group sharing and visibility safeguards #6

merged 39 commits into from
May 9, 2024

Conversation

davidcam-src
Copy link

https://unclibrary.atlassian.net/browse/HYC-1913

  • Added a non-visible admin set partial to the file set edit page to trigger conditional rendering of visibility options
  • Removing 'public' and 'registered' options from non-admin results of available_user_groups to prevent private works and files from being shared with groups that were not intended

@davidcam-src
adding admin sets to permission form to see if visibility component r…
f8defd0 
…enders differently
@davidcam-src
commiting change for availabe_user_groups
5722edd
@davidcam-src
moving admin set options to edit html
b16cd13
@davidcam-src
console log
350ee67
@davidcam-src
removing stuff from edit file
37127cf
@davidcam-src
rolling back change
00c056c
@davidcam-src
including admin set for delegate
890d4c7
@davidcam-src
temporary erb addition
6b2c79e
@davidcam-src
attempting admin set render in file set edit page
d509e9a
@davidcam-src
adding variable for fileset controller
7552806
@davidcam-src
adding duplicate to file_sets
0dbcf67
@davidcam-src
changing admin sets html
6719737
@davidcam-src
adding argument for admin set render
42e89ef
@davidcam-src
moving admin set render
fe5bd04
@davidcam-src
adding term to form
0e830d9
@davidcam-src
moving admin set render to file set form
e249600
@davidcam-src
admin set options
c3d7177
@davidcam-src
modified visibility component
03a50fc
@davidcam-src
including import
3f2e058
@davidcam-src
moving admin sets render
351b05b
@davidcam-src
moving admin sets render
38f7131
@davidcam-src
changed admin sets html
d797d63
@davidcam-src
updating admin set options
c48c564
@davidcam-src
logging statements
94a81ed
@davidcam-src
more logs
42c67bd
@davidcam-src
updating function name
206c949
@davidcam-src
using instance variable instead of function call
030d6e0
@davidcam-src
syntax
f0a5699
@davidcam-src
adding log
9cf5401
@davidcam-src
logs
223a0e7
bbpennel
bbpennel requested changes May 9, 2024
View reviewed changes
app/controllers/hyrax/file_sets_controller.rb Outdated Show resolved Hide resolved
app/presenters/hyrax/file_set_presenter.rb Outdated Show resolved Hide resolved
app/views/hyrax/file_sets/_permission.html.erb Outdated Show resolved Hide resolved
app/views/hyrax/file_sets/_admin_set_partial.html.erb Outdated Show resolved Hide resolved
@bbpennel bbpennel merged commit 1fcbb16 into unc-hyrax-4-development May 9, 2024
1 check passed
@bbpennel bbpennel deleted the hyc-1913 branch May 9, 2024 15:07
@davidcam-src davidcam-src mentioned this pull request May 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbpennel bbpennel bbpennel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@davidcam-src @bbpennel